Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't require parts to be unbroken for fake part generation #73596

Merged
merged 1 commit into from
May 10, 2024

Conversation

irwiss
Copy link
Contributor

@irwiss irwiss commented May 9, 2024

Summary

None

Purpose of change

Fix #71451

Describe the solution

Fake parts require unbroken real parts for generating the fake part, when a part goes to XX the relative_parts cache is still populated with the mount point of the fake part, but the part is no longer there and causes a debugmsg in display code that uses the cache for lookup.

Could also repopulate the relative_parts when a part damage goes to XX, but imo fake parts should be generated regardless of broken status, and a hit to the same mount point should still apply damage and finish breaking off the XX part

Describe alternatives you've considered

Testing

Scenario in linked issue works for testing

Additional context

@github-actions github-actions bot added Vehicles Vehicles, parts, mechanics & interactions [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels May 9, 2024
@ashGlaw
Copy link
Contributor

ashGlaw commented May 9, 2024

Yass! I've run into this bug many times. Thank you for squashing it

@dseguin dseguin merged commit 343e688 into CleverRaven:master May 10, 2024
24 of 28 checks passed
@irwiss irwiss deleted the veh-display-debugmsgs branch May 11, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions Vehicles Vehicles, parts, mechanics & interactions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error while turning cube van
3 participants