Don't require parts to be unbroken for fake part generation #73596
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Fix #71451
Describe the solution
Fake parts require unbroken real parts for generating the fake part, when a part goes to XX the
relative_parts
cache is still populated with the mount point of the fake part, but the part is no longer there and causes a debugmsg in display code that uses the cache for lookup.Could also repopulate the relative_parts when a part damage goes to XX, but imo fake parts should be generated regardless of broken status, and a hit to the same mount point should still apply damage and finish breaking off the XX part
Describe alternatives you've considered
Testing
Scenario in linked issue works for testing
Additional context