Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test to ensure unconditional and conditional nest placement works #73607

Merged
merged 8 commits into from
May 10, 2024

Conversation

Procyonae
Copy link
Contributor

@Procyonae Procyonae commented May 9, 2024

Summary

None

Purpose of change

Prevent a repeat of #67197

Describe the solution

The test checks each conditional placement method with both a condition that should resolve true and another that should resolve false, as well as an unconditional nest with an else_chunks for it's false test
Checks that om_terrain_match_type works in neighbors
Checks that if multiple conditions are used all must be true

Describe alternatives you've considered

Adding this sooner
Giving each nest an else_chunk with a false terrain so you have true/false/unplaced as opposed to placed/unplaced

Testing

Ran 550 times locally with no fails
(Running it 500 times on my not particularly powerful PC only took 27.88s, I love how fast code can be)

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Code: Tests Measurement, self-control, statistics, balancing. [C++] Changes (can be) made in C++. Previously named `Code` labels May 9, 2024
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels May 9, 2024
@Procyonae Procyonae marked this pull request as ready for review May 9, 2024 16:18
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label May 10, 2024
@I-am-Erk
Copy link
Member

A new test! Nice! Heroic work.

@I-am-Erk I-am-Erk merged commit 030dcc4 into CleverRaven:master May 10, 2024
21 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` Code: Tests Measurement, self-control, statistics, balancing. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants