Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip slow builds for draft PRs #73646

Merged
merged 6 commits into from
May 11, 2024
Merged

skip slow builds for draft PRs #73646

merged 6 commits into from
May 11, 2024

Conversation

kevingranade
Copy link
Member

@kevingranade kevingranade commented May 11, 2024

Summary

None

Purpose of change

CI has been getting turbo clogged recently, with action queues in the 60s and 70s on a regular basis.

Describe the solution

This simply cancels windows and clang-tidy builds when a PR is in draft.
Then it does kick off another build when you take it out of draft, but if you push just a few times before taking it out of draft that easily comes out ahead.

Describe alternatives you've considered

It's possible we could use some kind of labelling to opt in or out instead?
We would get the same benefits by moving the windows and clang-tidy actions to the end of the matrix build job like in #73615 , that would also prevent these jobs from running in parallel, which should reduce time to first test run across all PRs.

Testing

It's just YAML what could go wrong.
Hah jk, I'll put this in draft and it should skip the heavy builds, which I THINK will run because I'm touching one of the workflow files.

@github-actions github-actions bot added Code: Tooling Tooling that is not part of the main game but is part of the repo. json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels May 11, 2024
@kevingranade
Copy link
Member Author

After fiddling with things, windows build skipped, clang-tidy action skipped, good.

@kevingranade kevingranade marked this pull request as ready for review May 11, 2024 03:34
@Maleclypse Maleclypse merged commit e84f3c1 into master May 11, 2024
17 of 23 checks passed
@kevingranade kevingranade deleted the kevingranade-leaner-drafts branch May 11, 2024 04:53
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label May 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Code: Tooling Tooling that is not part of the main game but is part of the repo. json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants