-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
skip slow builds for draft PRs #73646
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevingranade
commented
May 11, 2024
kevingranade
commented
May 11, 2024
kevingranade
commented
May 11, 2024
kevingranade
commented
May 11, 2024
github-actions
bot
added
Code: Tooling
Tooling that is not part of the main game but is part of the repo.
json-styled
JSON lint passed, label assigned by github actions
astyled
astyled PR, label is assigned by github actions
labels
May 11, 2024
After fiddling with things, windows build skipped, clang-tidy action skipped, good. |
github-actions
bot
added
the
BasicBuildPassed
This PR builds correctly, label assigned by github actions
label
May 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
astyled
astyled PR, label is assigned by github actions
BasicBuildPassed
This PR builds correctly, label assigned by github actions
Code: Tooling
Tooling that is not part of the main game but is part of the repo.
json-styled
JSON lint passed, label assigned by github actions
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
CI has been getting turbo clogged recently, with action queues in the 60s and 70s on a regular basis.
Describe the solution
This simply cancels windows and clang-tidy builds when a PR is in draft.
Then it does kick off another build when you take it out of draft, but if you push just a few times before taking it out of draft that easily comes out ahead.
Describe alternatives you've considered
It's possible we could use some kind of labelling to opt in or out instead?
We would get the same benefits by moving the windows and clang-tidy actions to the end of the matrix build job like in #73615 , that would also prevent these jobs from running in parallel, which should reduce time to first test run across all PRs.
Testing
It's just YAML what could go wrong.
Hah jk, I'll put this in draft and it should skip the heavy builds, which I THINK will run because I'm touching one of the workflow files.