Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak Wind Turbine Recipe Learning #73649

Merged
merged 2 commits into from
May 14, 2024

Conversation

TheMurderUnicorn
Copy link
Contributor

Summary

Balance "Tweak Wind Turbine Recipe Learning"

Purpose of change

Both the Wind Turbine and Large Wind Turbine were autolearned recipes that also could be learned from books. However, learning from books ALL required that your skill level be so high you would have already autolearned the recipes. This means you will never learn them from the books, which is not very dynamic or probably how it should be.

Describe the solution

Okay, so I removed books entirely from the wind turbine – lowering the book levels to below the autolearn levels makes no sense as 2 of the 3 can’t even be read at that skill level, and whats a transistor probably shouldn’t even have these recipes. So, removed the books from wind turbine. TLDR: nothing changed about how this behaves in game currently

Large wind turbine has more play to it, I have lowered the book recipe autolearn levels to level 4 (it’s autolearned at level 5). This makes all the books viable for learning this recipe a level early, giving them value once again. I debated removing what’s a transistor from this list entirely, because most likely it would be more difficult to learn from that book and I can't implement that, but ultimately chose to leave it because I don’t know whatever, someone thought it was appropriate before.

Describe alternatives you've considered

I debated removing both from Whats a Transistor, because that’s a pretty basic ass book to be making big turbines, but whatever I left it. I also considered removing it from all books and just having the large turbine also be autolearned, but I like this better, because it brings more value to those books while still being balanced and reasonable.

Testing

Basically just checked in the game that they were showing/not showing in the books appropriately.

Additional context

Is this even worth it? There's a lot of recipes like this, that are autolearned early, reducing the value of their books. Erk made an issue about gradual learning/research/however we'd phrase that instead of just poof you autolearned 4 dozen recipes because you gained a level. Should I not be bothering until something like that was implemented or should I try to hit these as I spot them?

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Game: Balance Balancing of (existing) in-game features. astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels May 11, 2024
@Maleclypse Maleclypse merged commit e3c105a into CleverRaven:master May 14, 2024
18 of 24 checks passed
@TheMurderUnicorn TheMurderUnicorn deleted the TurbineTweak branch May 14, 2024 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Game: Balance Balancing of (existing) in-game features. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants