Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limbify consume speed modifiers #73827

Merged
merged 2 commits into from
May 17, 2024
Merged

Conversation

Venera3
Copy link
Member

@Venera3 Venera3 commented May 16, 2024

Summary

Features "Limbify consumption times"

Purpose of change

More limby systems = more better.
This time it's the consumption time modifier, differentiated into liquids and solids.

Describe the solution

Added two new scores and derived character modifiers for consuming solids/liquids respectively.
Added a unit test.
Updated docs.

Describe alternatives you've considered

Go through a single score, but the point of this is to have more granularity not less.

Testing

Checked eating hamburgers with a debug tail, got faster. Drinking was unaffected.
Unit tests passed.

Additional context

@github-actions github-actions bot added <Documentation> Design documents, internal info, guides and help. [JSON] Changes (can be) made in JSON Code: Tests Measurement, self-control, statistics, balancing. [C++] Changes (can be) made in C++. Previously named `Code` [Markdown] Markdown issues and PRs Limbs Limbs, mutable limbs, and code related to them. <Enhancement / Feature> New features, or enhancements on existing labels May 16, 2024
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels May 16, 2024
@Maleclypse Maleclypse merged commit c3b29e0 into CleverRaven:master May 17, 2024
22 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` Code: Tests Measurement, self-control, statistics, balancing. <Documentation> Design documents, internal info, guides and help. <Enhancement / Feature> New features, or enhancements on existing [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Limbs Limbs, mutable limbs, and code related to them. [Markdown] Markdown issues and PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants