Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retain non-solid contents when installing vehicle parts #73860

Merged
merged 1 commit into from
May 17, 2024

Conversation

irwiss
Copy link
Contributor

@irwiss irwiss commented May 16, 2024

Summary

None

Purpose of change

Limit the spilling action of #64846 so batteries don't instantly discharge, tanks don't lose gasses/liquids etc when installing as parts to vehicles (or doing any other stuff that passes via crafting consuming).

Describe the solution

Spill contents only when solids are inside

Describe alternatives you've considered

Testing

Spawn/get a storage battery with some charge in it or a propane tank with some propane in it, install to vehicle, battery shouldn't instantly discharge, propane shouldn't spill

Additional context

@github-actions github-actions bot added Crafting / Construction / Recipes Includes: Uncrafting / Disassembling [C++] Changes (can be) made in C++. Previously named `Code` astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels May 16, 2024
@Maleclypse Maleclypse merged commit 03d8ffb into CleverRaven:master May 17, 2024
29 checks passed
@irwiss irwiss deleted the retain-non-solids branch May 17, 2024 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` Crafting / Construction / Recipes Includes: Uncrafting / Disassembling json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants