Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Xedra] Give Homullus Equipment Durability Mutation with New Enchant #73918

Merged
merged 6 commits into from
May 20, 2024

Conversation

b3brodie
Copy link
Contributor

Summary

Mods "Add new homullus mutations that increase equipment durability"

Purpose of change

Add new Homullus mutations that expand the categories focus on used equipment.

Describe the solution

Adds a new enchantment that alters the chance that weapons and armor (and clothes) take damage when used.
Adds two new mutations: equipment hardening and extreme equipment hardening, which reduce the likelihood to take damage by 33 and 66 percent, with the stronger mutation gated by threshold.
Adds the enchant to the homullus transformation ability at 100% resist to represent homulluses fully going into their element.

Describe alternatives you've considered

Splitting the enchantment into separate enchants for armor and weapon durability.
Adding the enchantment to other paraclesians, such as a combined Salamander mutation that increases armor value but decreased armor durability. Not sure of a good balance for that though.

Testing

Used flimsy equipment to clearly see differences in performance
Test Cases:
Flimsy Spear + Durability: multiply 99 = damaged every hit. Completely destroyed in 4 hits
Flimsy Spear + Durability: multiply -1 = completely invulnerable. Not damaged after several hundred hits
Cardboard Armor + Durability: multiply 99 = instantly destroyed on hit.
Cardboard Armor + Durability: multiply -1 = invulnerable. Never damaged despite active hulk attacks.

Additional context

N/A

@b3brodie b3brodie changed the title [Xedra] Give Homullus Equipment Durability Mutation with new enchant [Xedra] Give Homullus Equipment Durability Mutation with New Enchant May 19, 2024
@github-actions github-actions bot added <Documentation> Design documents, internal info, guides and help. [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies [C++] Changes (can be) made in C++. Previously named `Code` [Markdown] Markdown issues and PRs Melee Melee weapons, tactics, techniques, reach attack Mechanics: Enchantments / Spells Enchantments and spells Items: Armor / Clothing Armor and clothing Mods: Xedra Evolved Anything to do with Xedra Evolved labels May 19, 2024
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels May 19, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label May 19, 2024
@Maleclypse
Copy link
Member

This is a perfect addition for homullus! Thank you!

@Maleclypse Maleclypse merged commit 252164d into CleverRaven:master May 20, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` <Documentation> Design documents, internal info, guides and help. Items: Armor / Clothing Armor and clothing [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions [Markdown] Markdown issues and PRs Mechanics: Enchantments / Spells Enchantments and spells Melee Melee weapons, tactics, techniques, reach attack Mods: Xedra Evolved Anything to do with Xedra Evolved Mods Issues related to mods or modding Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants