Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disassembly documentation #73929

Merged
merged 14 commits into from
Jul 10, 2024
Merged

Conversation

Karol1223
Copy link
Contributor

@Karol1223 Karol1223 commented May 19, 2024

Summary

None

Purpose of change

Part of #73410 and probably the only one I can do myself

Describe the solution

Documentation regarding the different ways to handle item disassembly, how to choose the method, and what to look out for when adding new disassembly recipes or editing current ones

Link directly to the readable version https://github.com/Karol1223/Cataclysm-DDA/blob/disassembly-doc/doc/ITEM_DISASSEMBLY.md

Describe alternatives you've considered

Testing

Big Dev made me read the docs, by tricking me into reading my own work to make sure I wasn't lying.

Additional context

Since most of this information was already known to me I don't really know how helpful this is. I desperately need people to proofread this for me to make sure this is understandable and makes sense. And if there's anything else this doc should have, tell me and I'll see if it makes sense to add it.

@github-actions github-actions bot added <Documentation> Design documents, internal info, guides and help. [Markdown] Markdown issues and PRs labels May 19, 2024
@Hyperseeker
Copy link
Contributor

Note that (at least in 0.H) you can add proficiencies to uncraft recipes. They're valid, structurally, but they don't seem to do anything: disassembling with such a recipe doesn't improve/provide proficiency progress, and the time offset is not taken into account, either with the time displayed in the menu/item description or the time of disassembly.

I think it's worth noting that it's possible but meaningless (at least so far), in case someone figures out to try it.

@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels May 19, 2024
@github-actions github-actions bot removed the BasicBuildPassed This PR builds correctly, label assigned by github actions label May 25, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jun 7, 2024
@Karol1223 Karol1223 marked this pull request as ready for review June 30, 2024 11:42
@Maleclypse Maleclypse merged commit 001c76f into CleverRaven:master Jul 10, 2024
16 of 21 checks passed
@Karol1223 Karol1223 deleted the disassembly-doc branch July 10, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Documentation> Design documents, internal info, guides and help. json-styled JSON lint passed, label assigned by github actions [Markdown] Markdown issues and PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants