Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the MR73 #74636

Merged
merged 4 commits into from
Jun 19, 2024
Merged

Remove the MR73 #74636

merged 4 commits into from
Jun 19, 2024

Conversation

BalthazarArgall
Copy link
Contributor

@BalthazarArgall BalthazarArgall commented Jun 17, 2024

Summary

None

Purpose of change

While working on the Chiappa Rhino I noticed that the Manurhin MR73 was in the game, which is surprising given its rarity, after checking on gunbroker it turns out that not only is it rare but it's way below the inclusion standard.

Describe the solution

Migrate it and replace it with a similar revolver.

Describe alternatives you've considered

Testing

None.

Additional context

I can't access the completed listings due to not being a US citizen, maybe if you include them you meet the standards although I'd be surprised if it made much of a difference.

Gunbroker screenshot:
Untitled

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Spawn Creatures, items, vehicles, locations appearing on map Code: Tests Measurement, self-control, statistics, balancing. Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves Mods: Generic Guns Anything to do with Generic Guns labels Jun 17, 2024
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Jun 17, 2024
@BalthazarArgall
Copy link
Contributor Author

Remind me to not work on 2 PRs touching the same files at the same time again

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jun 18, 2024
@BalthazarArgall BalthazarArgall marked this pull request as ready for review June 18, 2024 14:33
@kevingranade
Copy link
Member

Here the hits for completed listings
Screenshot_20240618_073853_Firefox
, as expected...

@Maleclypse Maleclypse merged commit b67ff6c into CleverRaven:master Jun 19, 2024
49 checks passed
@Griffinhart
Copy link
Contributor

Griffinhart commented Jun 21, 2024

Why are y'all looking up MR73s on Gunbroker? (I see mention of "inclusion standard" but I don't know where/what that is.)

Beretta is the official US importer for the MR73 and it can be purchased brand-new. They're not rare, they're just an expensive (~3700USD) niche (revolver) gun.

https://gun.deals/search/apachesolr_search/mr73

I see listings from Eurooptic, Gunprime, and Guns dot com.

@KrunkySmokin
Copy link

Why are y'all looking up MR73s on Gunbroker? (I see mention of "inclusion standard" but I don't know where/what that is.)

Beretta is the official US importer for the MR73 and they can be purchased brand-new.

https://gun.deals/search/apachesolr_search/mr73

I see listings from Eurooptic, Gunprime, and Guns dot com.

I don't get the removal of any of the recent guns when they have a tent gun show that spawns that could reasonably contain any of these harder to find weapons.

@BalthazarArgall
Copy link
Contributor Author

Why are y'all looking up MR73s on Gunbroker? (I see mention of "inclusion standard" but I don't know where/what that is.)

Beretta is the official US importer for the MR73 and it can be purchased brand-new. They're not rare, they're just an expensive (~3700USD) niche (revolver) gun.

https://gun.deals/search/apachesolr_search/mr73

I see listings from Eurooptic, Gunprime, and Guns dot com.

Unless I'm misunderstanding this is evidence of the possibility of purchase, not evidence of the item being present in New England in the minimum amount required to be represented in the game.

@BalthazarArgall
Copy link
Contributor Author

BalthazarArgall commented Jun 21, 2024

Why are y'all looking up MR73s on Gunbroker? (I see mention of "inclusion standard" but I don't know where/what that is.)
Beretta is the official US importer for the MR73 and they can be purchased brand-new.
https://gun.deals/search/apachesolr_search/mr73
I see listings from Eurooptic, Gunprime, and Guns dot com.

I don't get the removal of any of the recent guns when they have a tent gun show that spawns that could reasonably contain any of these harder to find weapons.

Indeed the gun show is an excellent way to give players a way to access guns that both meet the requirements for inclusion and are rare. The issue with the MR73 is that it only meets one of those requirements.

@harakka
Copy link
Contributor

harakka commented Jun 21, 2024

Why are y'all looking up MR73s on Gunbroker?

https://github.com/CleverRaven/Cataclysm-DDA/blob/master/doc/GUN_NAMING_AND_INCLUSION.md

The comments of this already merged PR are not the place to debate this, if you have a better methodology make an issue explaining it.

@BalthazarArgall BalthazarArgall deleted the RemoveMR73 branch June 21, 2024 15:24
@KrunkySmokin
Copy link

Why are y'all looking up MR73s on Gunbroker? (I see mention of "inclusion standard" but I don't know where/what that is.)
Beretta is the official US importer for the MR73 and they can be purchased brand-new.
https://gun.deals/search/apachesolr_search/mr73
I see listings from Eurooptic, Gunprime, and Guns dot com.

I don't get the removal of any of the recent guns when they have a tent gun show that spawns that could reasonably contain any of these harder to find weapons.

Indeed the gun show is an excellent way to give players a way to access guns that both meet the requirements for inclusion and are rare. The issue with the MR73 is that it only meets one of those requirements.

If you're going by that then you may as well start removing non-military/police machine guns because of how rare those are in New England. The MR73 is still currently in production and to a degree that Beretta sees it profitable to import to sell.

@BalthazarArgall
Copy link
Contributor Author

BalthazarArgall commented Jun 21, 2024

If you're going by that then you may as well start removing non-military/police machine guns because of how rare those are in New England. The MR73 is still currently in production and to a degree that Beretta sees it profitable to import to sell.

Indeed. We already started removing some machineguns. As for your other point, I already addressed it:

[...]this is evidence of the possibility of purchase, not evidence of the item being present in New England in the minimum amount required to be represented in the game.

@KrunkySmokin
Copy link

KrunkySmokin commented Jun 21, 2024

If you're going by that then you may as well start removing non-military/police machine guns because of how rare those are in New England. The MR73 is still currently in production and to a degree that Beretta sees it profitable to import to sell.

Indeed. We already started removing some machineguns. As for your other point, I already addressed it:

[...]this is evidence of the possibility of purchase, not evidence of the item being present in New England in the minimum amount required to be represented in the game.

Maybe fix existing guns and the months long bugs where interchangeable barrels on certain rifles aren't spawning there instead of removing guns, guns that could fit in at a gun show. Gun shows where collectors bring their guns to show off and trade. Having a gun show and having that "it has to be prominent enough in New England" rule for gun inclusion makes no sense.

@BalthazarArgall
Copy link
Contributor Author

Maybe fix existing guns and the months long bugs where interchangeable barrels on certain rifles aren't spawning there instead of removing guns, guns that could fit in at a gun show. Gun shows where collectors bring their guns to show off and trade. Having a gun show and having that "it has to be prominent enough in New England" rule for gun inclusion makes no sense.

We can both fix the bugs and remove the guns at the same time. I already explained how guns can be rare and still meet the requirements for inclusion, justifying their presence at a gun show.

@KrunkySmokin
Copy link

KrunkySmokin commented Jun 21, 2024

Maybe fix existing guns and the months long bugs where interchangeable barrels on certain rifles aren't spawning there instead of removing guns, guns that could fit in at a gun show. Gun shows where collectors bring their guns to show off and trade. Having a gun show and having that "it has to be prominent enough in New England" rule for gun inclusion makes no sense.

We can both fix the bugs and remove the guns at the same time. I already explained how guns can be rare and still meet the requirements for inclusion, justifying their presence at a gun show.

None of what you've said above explains how they can also meet the requirements for inclusion of a gun if rare because by virtue of them being rare, they're being removed from the game by you. There is a completely viable place they could be found instead.

@BalthazarArgall
Copy link
Contributor Author

None of what you've said above explains how they can also meet the requirements for inclusion of a gun if rare because by virtue of them being rare, they're being removed from the game by you. There is a completely viable place they could be found instead.

That's because we make a distinction between "rare" and "too rare for inclusion".

@CleverRaven CleverRaven locked as resolved and limited conversation to collaborators Jun 21, 2024
@Maleclypse
Copy link
Member

Maybe fix existing guns and the months long bugs where interchangeable barrels on certain rifles aren't spawning there instead of removing guns, guns that could fit in at a gun show. Gun shows where collectors bring their guns to show off and trade. Having a gun show and having that "it has to be prominent enough in New England" rule for gun inclusion makes no sense.

We can both fix the bugs and remove the guns at the same time. I already explained how guns can be rare and still meet the requirements for inclusion, justifying their presence at a gun show.

None of what you've said above explains how they can also meet the requirements for inclusion of a gun if rare because by virtue of them being rare, they're being removed from the game by you. There is a completely viable place they could be found instead.

As mentioned above completed PRs are not the place to be discussing this. If you ignore requests to change the venue of a conversation again in the future it could result in removal of your ability to comment on this repo.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Code: Tests Measurement, self-control, statistics, balancing. Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Generic Guns Anything to do with Generic Guns Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants