Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix vitamin enchantment condition #74929

Merged
merged 3 commits into from
Jul 7, 2024

Conversation

GuardianDll
Copy link
Member

@GuardianDll GuardianDll commented Jul 6, 2024

Summary

None

Purpose of change

fix #74923

Describe the solution

Apply fix suggested by Andrei
Also fix vision_range in the same manner

Testing

Compiled, applied next traits

  {
    "type": "mutation",
    "id": "DEBUG_TEST",
    "name": { "str": "DEBUG_TEST" },
    "points": 2,
    "description": "DEBUG_TEST.",
    "enchantments": [ { "values": [ { "value": "LUMINATION", "add": { "math": [ "u_vitamin('bad_food') * 10" ] } } ] } ]
  },
  {
    "type": "mutation",
    "id": "DEBUG_TEST",
    "name": { "str": "DEBUG_TEST" },
    "points": 2,
    "description": "DEBUG_TEST.",
    "enchantments": [ { "values": [ { "value": "LUMINATION", "add": { "math": [ "u_vision_range()" ] } } ] } ]
  },

For first, consumed some protein rations, observed me glowing more the more vitamins got processed
For second, saw the 6 range of light with default character, debugged near-sighted mutation, got only 2 tile range of light

Additional context

Andrei told vision_range need a same treatment, but i sadly have difficulties to bite what this code does, so it's hard to apply fixed

@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` <Bugfix> This is a fix for a bug (or closes open issue) labels Jul 6, 2024
src/math_parser_diag.cpp Outdated Show resolved Hide resolved
src/math_parser_diag.cpp Outdated Show resolved Hide resolved
src/math_parser_diag.cpp Outdated Show resolved Hide resolved
@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Jul 6, 2024
src/math_parser_diag.cpp Outdated Show resolved Hide resolved
src/math_parser_diag.cpp Outdated Show resolved Hide resolved
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Jul 6, 2024
@Maleclypse Maleclypse merged commit 79f0cfd into CleverRaven:master Jul 7, 2024
25 of 26 checks passed
@Maleclypse Maleclypse deleted the fix_vitamins branch July 7, 2024 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

u_vitamin enchantment conditions do not work
2 participants