Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Xedra Evolved] Paraclesian morale effects scale #74953

Merged
merged 2 commits into from
Jul 9, 2024

Conversation

Standing-Storm
Copy link
Contributor

@Standing-Storm Standing-Storm commented Jul 8, 2024

Summary

Mods "[Xedra Evolved] Paraclesian morale effects scale"

Purpose of change

Morale effects can scale with math, so they should.

Describe the solution

Makes the morale bonus of the Arvore spell Commune with Nature and the Homullus spell Everything Will Be Fine scale with spell level and attributes.

Since the max bonus is now much higher, the spell removes the previous morale before adding a new one, to prevent stacking it too high.

Describe alternatives you've considered

Testing

Morale bonus is variable, effects do not stack.

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding EOC: Effects On Condition Anything concerning Effects On Condition Mods: Xedra Evolved Anything to do with Xedra Evolved labels Jul 8, 2024
@github-actions github-actions bot requested a review from Maleclypse July 8, 2024 19:33
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Jul 8, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jul 8, 2024
@Maleclypse Maleclypse merged commit 5c033a6 into CleverRaven:master Jul 9, 2024
21 of 26 checks passed
@Standing-Storm Standing-Storm deleted the scaling-morale branch July 9, 2024 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions EOC: Effects On Condition Anything concerning Effects On Condition [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Xedra Evolved Anything to do with Xedra Evolved Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants