Make GHA run on julia 1.9 #1417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charleskawczynski
force-pushed
the
ck/julia19GHA
branch
4 times, most recently
from
46d61d5
to
710fdaf
Compare
simonbyrne
approved these changes
Aug 8, 2023
|
bors r+ |
1 similar comment
|
bors r+ |
|
Already running a review |
bors bot
added a commit
that referenced
this pull request
Aug 8, 2023
1417: Make GHA run on julia 1.9 r=charleskawczynski a=charleskawczynski It might be nice to incrementally merge #1235. The main thing holding it back is issues with the shared depot path. One thing we can do is start running ClimaCore on 1.9 in GHA, and fix the inference issues that occur from upgrading, without having to deal with the shared depot path issue. I don't love the idea of being straddled between versions, but the only breaking differences seem to be inference, which I suspect we can fix for both versions without too much headache. Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
|
Timed out. |
charleskawczynski
force-pushed
the
ck/julia19GHA
branch
from
695cef7
to
027fe0a
Compare
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Aug 9, 2023
1417: Make GHA run on julia 1.9 r=charleskawczynski a=charleskawczynski It might be nice to incrementally merge #1235. The main thing holding it back is issues with the shared depot path. One thing we can do is start running ClimaCore on 1.9 in GHA, and fix the inference issues that occur from upgrading, without having to deal with the shared depot path issue. I don't love the idea of being straddled between versions, but the only breaking differences seem to be inference, which I suspect we can fix for both versions without too much headache. Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
|
Timed out. |
charleskawczynski
force-pushed
the
ck/julia19GHA
branch
from
027fe0a
to
293b073
Compare
|
bors r+ |
|
Already running a review |
bors bot
added a commit
that referenced
this pull request
Aug 9, 2023
1417: Make GHA run on julia 1.9 r=charleskawczynski a=charleskawczynski It might be nice to incrementally merge #1235. The main thing holding it back is issues with the shared depot path. One thing we can do is start running ClimaCore on 1.9 in GHA, and fix the inference issues that occur from upgrading, without having to deal with the shared depot path issue. I don't love the idea of being straddled between versions, but the only breaking differences seem to be inference, which I suspect we can fix for both versions without too much headache. Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
|
Ah, bors is not matching on the status, since we've added (not just replaced 1.8.5 with 1.9). I guess the simples solution would be to replace it since that should make the status look the same, do we want to keep GHA tests on 1.8? cc @simonbyrne |
|
Being that this PR doesn't fully convert us to 1.9, I'll try to keep 1.8, too |
|
Actually, doing that would involve involve changing the GHA yaml a bit, I'd rather keep this simple, and we'll still be testing on 1.8 on buildkite. |
|
Canceled. |
|
bors r+ |
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors bot
added a commit
that referenced
this pull request
Aug 10, 2023
1420: Update buildkite to 1.9 r=simonbyrne a=simonbyrne My fork of #1417 - [ ] Code follows the [style guidelines](https://clima.github.io/ClimateMachine.jl/latest/DevDocs/CodeStyle/) OR N/A. - [ ] Unit tests are included OR N/A. - [ ] Code is exercised in an integration test OR N/A. - [ ] Documentation has been added/updated OR N/A. Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com> Co-authored-by: Simon Byrne <simonbyrne@gmail.com>
bors bot
added a commit
that referenced
this pull request
Aug 11, 2023
1420: Update buildkite to 1.9 r=simonbyrne a=simonbyrne My fork of #1417 - [ ] Code follows the [style guidelines](https://clima.github.io/ClimateMachine.jl/latest/DevDocs/CodeStyle/) OR N/A. - [ ] Unit tests are included OR N/A. - [ ] Code is exercised in an integration test OR N/A. - [ ] Documentation has been added/updated OR N/A. Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com> Co-authored-by: Simon Byrne <simonbyrne@gmail.com>
bors bot
added a commit
that referenced
this pull request
Aug 11, 2023
1420: Update buildkite to 1.9 r=simonbyrne a=simonbyrne My fork of #1417 - [ ] Code follows the [style guidelines](https://clima.github.io/ClimateMachine.jl/latest/DevDocs/CodeStyle/) OR N/A. - [ ] Unit tests are included OR N/A. - [ ] Code is exercised in an integration test OR N/A. - [ ] Documentation has been added/updated OR N/A. Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com> Co-authored-by: Simon Byrne <simonbyrne@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It might be nice to incrementally merge #1235. The main thing holding it back is issues with the shared depot path. One thing we can do is start running ClimaCore on 1.9 in GHA, and fix the inference issues that occur from upgrading, without having to deal with the shared depot path issue.
I don't love the idea of being straddled between versions, but the only breaking differences seem to be inference, which I suspect we can fix for both versions without too much headache.