Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to julia 1.9 #1235

Closed
wants to merge 11 commits into from
Closed

Upgrade to julia 1.9 #1235

wants to merge 11 commits into from

Conversation

charleskawczynski
Copy link
Member

@charleskawczynski charleskawczynski commented May 10, 2023 •
edited by simonbyrne
Loading

This PR upgrades to julia 1.9

Blockers

@charleskawczynski
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request May 10, 2023
@bors
Try #1235:
d5daecc
@bors
Copy link
Contributor

bors bot commented May 10, 2023

try

Build failed:

@juliasloan25 juliasloan25 mentioned this pull request May 23, 2023
Closed
@charleskawczynski charleskawczynski marked this pull request as draft May 28, 2023 15:44
@charleskawczynski charleskawczynski force-pushed the ck/julia19_again branch 2 times, most recently from d56a64a to d1873b1 Compare May 30, 2023 23:29
@charleskawczynski
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Jun 7, 2023
@bors
Try #1235:
fee56aa
@bors
Copy link
Contributor

bors bot commented Jun 7, 2023

try

Build failed:

@charleskawczynski charleskawczynski force-pushed the ck/julia19_again branch 3 times, most recently from cc08b21 to 44c2f9f Compare June 8, 2023 22:42
@simonbyrne
Copy link
Member

bors try

bors bot added a commit that referenced this pull request Jun 9, 2023
@bors
Try #1235:
7b50439
@bors
Copy link
Contributor

bors bot commented Jun 9, 2023

try

Build failed:

@simonbyrne
Copy link
Member

bors try

bors bot added a commit that referenced this pull request Jun 12, 2023
@bors
Try #1235:
f0dc1b4
@bors
Copy link
Contributor

bors bot commented Jun 12, 2023

try

Build failed:

@simonbyrne
Copy link
Member

bors try

bors bot added a commit that referenced this pull request Jun 12, 2023
@bors
Try #1235:
e449502
@bors
Copy link
Contributor

bors bot commented Jun 12, 2023

try

Build failed:

@simonbyrne
Copy link
Member

bors try

bors bot added a commit that referenced this pull request Jun 13, 2023
@bors
Try #1235:
c520b77
@bors
Copy link
Contributor

bors bot commented Jun 13, 2023

try

Build failed:

@simonbyrne
Copy link
Member

bors try

bors bot added a commit that referenced this pull request Jun 13, 2023
@bors
Try #1235:
661bde1
@charleskawczynski
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Aug 5, 2023
@bors
Try #1235:
4a5afea
@bors
Copy link
Contributor

bors bot commented Aug 5, 2023

try

Build failed:

@charleskawczynski
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Aug 8, 2023
@bors
Try #1235:
d3c2abe
@bors
Copy link
Contributor

bors bot commented Aug 8, 2023

try

Build failed:

@charleskawczynski
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Aug 8, 2023
@bors
Try #1235:
0d0d2be
@bors
Copy link
Contributor

bors bot commented Aug 8, 2023

try

Build failed:

@charleskawczynski
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Aug 8, 2023
@bors
Try #1235:
e897702
@bors
Copy link
Contributor

bors bot commented Aug 8, 2023

try

Build failed:

@charleskawczynski charleskawczynski mentioned this pull request Aug 8, 2023
Merged
bors bot added a commit that referenced this pull request Aug 8, 2023
@bors @charleskawczynski
Merge #1417
aa6ff55 
1417: Make GHA run on julia 1.9 r=charleskawczynski a=charleskawczynski

It might be nice to incrementally merge #1235. The main thing holding it back is issues with the shared depot path. One thing we can do is start running ClimaCore on 1.9 in GHA, and fix the inference issues that occur from upgrading, without having to deal with the shared depot path issue.

I don't love the idea of being straddled between versions, but the only breaking differences seem to be inference, which I suspect we can fix for both versions without too much headache.

Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
bors bot added a commit that referenced this pull request Aug 9, 2023
@bors @charleskawczynski
Merge #1417
20d7ce5 
1417: Make GHA run on julia 1.9 r=charleskawczynski a=charleskawczynski

It might be nice to incrementally merge #1235. The main thing holding it back is issues with the shared depot path. One thing we can do is start running ClimaCore on 1.9 in GHA, and fix the inference issues that occur from upgrading, without having to deal with the shared depot path issue.

I don't love the idea of being straddled between versions, but the only breaking differences seem to be inference, which I suspect we can fix for both versions without too much headache.

Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
bors bot added a commit that referenced this pull request Aug 9, 2023
@bors @charleskawczynski
Merge #1417
861a4d0 
1417: Make GHA run on julia 1.9 r=charleskawczynski a=charleskawczynski

It might be nice to incrementally merge #1235. The main thing holding it back is issues with the shared depot path. One thing we can do is start running ClimaCore on 1.9 in GHA, and fix the inference issues that occur from upgrading, without having to deal with the shared depot path issue.

I don't love the idea of being straddled between versions, but the only breaking differences seem to be inference, which I suspect we can fix for both versions without too much headache.

Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
bors bot added a commit that referenced this pull request Aug 9, 2023
@bors @charleskawczynski
Merge #1417
55b7014 
1417: Make GHA run on julia 1.9 r=charleskawczynski a=charleskawczynski

It might be nice to incrementally merge #1235. The main thing holding it back is issues with the shared depot path. One thing we can do is start running ClimaCore on 1.9 in GHA, and fix the inference issues that occur from upgrading, without having to deal with the shared depot path issue.

I don't love the idea of being straddled between versions, but the only breaking differences seem to be inference, which I suspect we can fix for both versions without too much headache.

Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
@simonbyrne simonbyrne closed this Aug 18, 2023
@charleskawczynski charleskawczynski deleted the ck/julia19_again branch September 21, 2023 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonbyrne simonbyrne simonbyrne left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@charleskawczynski @simonbyrne