Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove dependencies on component model data strucutres #332

Closed
4 tasks
Tracked by #358
LenkaNovak opened this issue Jun 27, 2023 · 1 comment
Closed
4 tasks
Tracked by #358

remove dependencies on component model data strucutres #332

LenkaNovak opened this issue Jun 27, 2023 · 1 comment
Assignees

Comments

@LenkaNovak
Copy link
Collaborator

LenkaNovak commented Jun 27, 2023

  • to make our code more modular and general we need to remove the remaining dependencies on component model data structures (e.g., integrator.p.) in the src/ code (especially in ConservationChecker, where we need to add more general unit tests). viz_explorer.jl should be generalized as well.

Components

  • write wrapper function for instances where we call integrator.p. and move them to the component/init... files. The wrappers should live in the source code
    • e.g. generalize definitions of get_slab_energy
  • revamp all relevant unit tests

QA

  • physical and conservation tests should be unchanged
  • no significant difference in performance
@LenkaNovak LenkaNovak changed the title remove the remaining dependencies on component model data strucutres (e.g., integrator.p.) in the src code (expecilly in ConservationChecker, where we need to add more general unit tests) remove dependencies on component model data strucutres Jun 27, 2023
@juliasloan25
Copy link
Member

juliasloan25 commented Oct 2, 2023

this has been completed via #436

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants