You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
to make our code more modular and general we need to remove the remaining dependencies on component model data structures (e.g., integrator.p.) in the src/ code (especially in ConservationChecker, where we need to add more general unit tests). viz_explorer.jl should be generalized as well.
Components
write wrapper function for instances where we call integrator.p. and move them to the component/init... files. The wrappers should live in the source code
e.g. generalize definitions of get_slab_energy
revamp all relevant unit tests
QA
physical and conservation tests should be unchanged
no significant difference in performance
The text was updated successfully, but these errors were encountered:
LenkaNovak
changed the title
remove the remaining dependencies on component model data strucutres (e.g., integrator.p.) in the src code (expecilly in ConservationChecker, where we need to add more general unit tests)
remove dependencies on component model data strucutres
Jun 27, 2023
integrator.p.
) in thesrc/
code (especially inConservationChecker
, where we need to add more general unit tests).viz_explorer.jl
should be generalized as well.Components
integrator.p.
and move them to thecomponent/init...
files. The wrappers should live in the source codeget_slab_energy
QA
The text was updated successfully, but these errors were encountered: