-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stabilizing CATKE for three-dimensional runs on ImmersedBoundaryGrid #3016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
navidcy
reviewed
Mar 23, 2023
New parameters for animate_les_data_with_catke.mp4Note the TKE variable has no dynamics, just a passive tracer for ri-based. |
CATKE is stunning as usual animate_les_data_with_catke.mp4 |
New default parameters for CATKE: julia> CATKEVerticalDiffusivity()
CATKEVerticalDiffusivity{VerticallyImplicitTimeDiscretization}
├── maximum_diffusivity: Inf
├── minimum_turbulent_kinetic_energy: 0.0
├── negative_turbulent_kinetic_energy_damping_time_scale: 60.0
├── minimum_convective_buoyancy_flux: 1.0e-11
├── mixing_length: CATKEVerticalDiffusivities.MixingLength
│ ├── Cᵇ: 0.37
│ ├── Cᶜc: 4.8
│ ├── Cᶜe: 1.1
│ ├── Cᵉc: 0.049
│ ├── Cᵉe: 0.0
│ ├── C⁻u: 0.36
│ ├── C⁻c: 0.41
│ ├── C⁻e: 6.7
│ ├── C⁺u: 0.24
│ ├── C⁺c: 0.12
│ ├── C⁺e: 5.4
│ ├── CRiʷ: 0.011
│ └── CRiᶜ: 0.76
└── turbulent_kinetic_energy_equation: CATKEVerticalDiffusivities.TurbulentKineticEnergyEquation
├── C⁻D: 4.4
├── C⁺D: 3.3
├── CᶜD: 0.23
├── CᵉD: 0.0
├── Cᵂu★: 1.8
└── CᵂwΔ: 12.0 |
navidcy
approved these changes
Mar 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to increase CATKE's stability for three-dimensional runs on ImmersedBoundaryGrid.
One crucial improvement is limiting
height_above_bottom
to no less than the grid spacing. (We weren't able to limit this by 0, we had to use a small positive number).A second improvement adds the parameter
minimum_convective_buoyancy_flux
. This parameter regularizes CATKE's convective mixing length, permitting smoother / less noisy estimates of the surface buoyancy flux. The convective mixing length is only activated if the surface buoyancy flux exceedsminimum_convective_buoyancy_flux
.