-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport #12089 to 20.5: Fix result_rows and result_bytes metrics for selects. #12239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merging #8624 (ssd-cache)
Extend word break config to all non-alphanumeric chars
Better diagnostics of "Replica {} appears to be already active" message
Fix bad log message at server startup
ISSUES-3985 Support MySQL engine reading Enums type
Add a test for #10102
Fix typos in code
Added a test for #8550
Fix potential FPE.
xeus-clickhouse is a Jupyter kernal for ClickHouse
Improve REVOKE command
…threads max_rows_to_read remove note about 'applied on each thread separately'
Test for input_format_allow_errors_num in CSV
…column ISSUES-4006 support first for ALTER ADD|MODIFY COLUMN
target_compile_definitions may only set INTERFACE properties on IMPORTED targets
* Add unbundled mode flag * Move skip lists to clickhouse-test * More verbose message about skip * Make skip-list optional * Update clickhouse-test
Add storage RabbitMQ
By default IMPORTED target has a scope in the directory in which it is created and below. This leads to the following issues when building UNBUNDLED: Target "clickhouse" links to target "Poco::Data::ODBC" but the target was not found. Perhaps a find_package() call is missing for an IMPORTED target, or an ALIAS target is missing?
* simplify reading in order of sorting key * add perf test for reading many parts * Revert "simplify reading in order of sorting key" This reverts commit 7267d7c. * add threshold for preliminary merge for reading in order * better threshold * limit threads in test
Added a showcase of minimal Docker image
Normalize "pid" file handling #3501
Minor cmake fixes for UNBUNDLED build
Fix Parquet for LowCardinality
Fix result_rows and result_bytes metrics for selects.
…54a9a46e70b6f166b1666f821a415 Cherry pick #12089 to 20.5: Fix result_rows and result_bytes metrics for selects.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original pull-request #12089
Cherry-pick pull-request #12209
This pull-request is a last step of an automated backporting.
Treat it as a standard pull-request: look at the checks and resolve conflicts.
Merge it only if you intend to backport changes to the target branch, otherwise just close it.