Replace old _shard_num implementation with shardNum() function #33392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-clickhouse
added
the
pr-improvement
Merged
|
Yeah, functions are better than literals. One test is broken. It seems the |
_shard_num via constant identifier (from ClickHouse#7624) has too much issues, take a look at ClickHouse#16947 for example. shardNum() function (from ClickHouse#27020) should works better. This changes the behaviour of _shard_num slightly, now it returns nested shard number in case of nested distributed tables (Distributed over Distributed), but this should be minor. v2: Rewrite _shard_num to shardNum() in TreeRewriter
- move CREATE/INSERT at the beginning - add echoOn
|
@alexey-milovidov can you please take a look? |
KochetovNicolai
approved these changes
Jan 27, 2022
|
I can't describe how I love this change. |
|
@Mergifyio update |
✅ Branch has been successfully updated |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Replace
_shard_numvia constants (from #7624) withshardNum()function (from #27020), to avoid possible issues (like those that had been found in #16947)Detailed description / Documentation draft:
This patch changes the behavior of _shard_num slightly for nested distributed tables,
now it returns nested shard number, but this should be minor.
Cc: @amosbird