Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supports all types of SYSTEM query ON CLUSTER clause. #34005

Merged
merged 9 commits into from
Jan 31, 2022

Conversation

nicelulu
Copy link
Contributor

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Supports all types of SYSTEM query ON CLUSTER clause.

@robot-clickhouse robot-clickhouse added the pr-improvement Pull request with some product improvements label Jan 26, 2022
@tavplubix tavplubix self-assigned this Jan 26, 2022
@tavplubix tavplubix added the can be tested Allows running workflows for external contributors label Jan 26, 2022
@tavplubix
Copy link
Member

Sorry, I was certain that all types are supported :)
#33856

@@ -1135,6 +1135,70 @@ def optimize(num):
for node in [node1, node2]:
node.query("DROP TABLE IF EXISTS replicated_table_for_moves SYNC")

def test_simple_replication_and_moves_on_cluster(start_cluster):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better to edit the original test than to copy-paste.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK.

@tavplubix
Copy link
Member

Sorry, builds were broken in master for a short period, let's restart
@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Jan 28, 2022

update

✅ Branch has been successfully updated

@nicelulu
Copy link
Contributor Author

nicelulu commented Jan 30, 2022

root@ZBMAC-C02DN6312 ~ % cat log/clickhouse-server.log |grep 'RELOAD DICTIONARIES'
2022.01.30 02:38:34.832368 [ 102133 ] {c45e74fb-c9cc-4d0f-84af-7c78e35a84bc} <Debug> executeQuery: (from [::1]:60760) (comment: 02179_dict_reload_on_cluster.sql) SELECT 'SYSTEM RELOAD DICTIONARIES ON CLUSTER test_shard_localhost';
2022.01.30 02:38:34.833140 [ 102133 ] {761fcebc-17e3-4dbc-aa7e-044db1eb42f6} <Debug> executeQuery: (from [::1]:60760) (comment: 02179_dict_reload_on_cluster.sql) SYSTEM RELOAD DICTIONARIES ON CLUSTER test_shard_localhost
2022.01.30 02:38:34.835780 [ 1073 ] {} <Debug> DDLWorker: Processing task query-0000001650 (SYSTEM RELOAD DICTIONARIES ON CLUSTER test_shard_localhost)
2022.01.30 02:38:34.836155 [ 1073 ] {} <Debug> DDLWorker: Executing query: SYSTEM RELOAD DICTIONARIES
2022.01.30 02:38:34.836247 [ 1073 ] {b5387fb7-d048-4c75-87be-2b6beaa3984b} <Debug> executeQuery: (from 0.0.0.0:0, user: ) (comment: 02179_dict_reload_on_cluster.sql) /* ddl_entry=query-0000001650 */ SYSTEM RELOAD DICTIONARIES
2022.01.30 02:38:34.837645 [ 1073 ] {b5387fb7-d048-4c75-87be-2b6beaa3984b} <Debug> DDLWorker: Executed query: SYSTEM RELOAD DICTIONARIES
2022.01.30 02:46:50.071410 [ 151117 ] {8f45061b-1acf-4ea9-84d7-aec343a0448c} <Debug> executeQuery: (from [::1]:47672) (comment: 01018_ddl_dictionaries_select.sql) SYSTEM RELOAD DICTIONARIES;
2022.01.30 02:46:50.074191 [ 151117 ] {8f45061b-1acf-4ea9-84d7-aec343a0448c} <Error> executeQuery: Code: 60. DB::Exception: Code: 60. DB::Exception: Table database_for_dict.table_for_dict doesn't exist. (UNKNOWN_TABLE) (version 22.2.1.3630). (UNKNOWN_TABLE) (version 22.2.1.3630) (from [::1]:47672) (comment: 01018_ddl_dictionaries_select.sql) (in query: SYSTEM RELOAD DICTIONARIES;), Stack trace (when copying this message, always include the lines below):

Seems to be interfered with by other test cases. How can this be avoided?

@tavplubix
Copy link
Member

Docs Check (actions) - looks unrelated, it was broken in master
Stateless tests (thread, actions) [1/3] - race in StorageFile, already fixed in master

@tavplubix tavplubix merged commit d0ea72f into ClickHouse:master Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
can be tested Allows running workflows for external contributors pr-improvement Pull request with some product improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants