Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add stateless tests with s3 storage with debug and tsan #35262

Merged
merged 17 commits into from
Sep 5, 2022
Merged

Add stateless tests with s3 storage with debug and tsan #35262

merged 17 commits into from
Sep 5, 2022

Conversation

kssenii
Copy link
Member

@kssenii kssenii commented Mar 14, 2022

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

@robot-clickhouse robot-clickhouse added the pr-not-for-changelog This PR should not be mentioned in the changelog label Mar 14, 2022
@kssenii
Copy link
Member Author

kssenii commented Apr 7, 2022

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Apr 7, 2022

update

✅ Branch has been successfully updated

@kssenii
Copy link
Member Author

kssenii commented Apr 12, 2022

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Apr 12, 2022

update

✅ Branch has been successfully updated

@kssenii
Copy link
Member Author

kssenii commented Apr 13, 2022

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Apr 13, 2022

update

✅ Branch has been successfully updated

@kssenii
Copy link
Member Author

kssenii commented Apr 19, 2022

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Apr 19, 2022

update

✅ Branch has been successfully updated

@alesapin
Copy link
Member

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Apr 29, 2022

update

✅ Branch has been successfully updated

@kssenii
Copy link
Member Author

kssenii commented May 6, 2022

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented May 6, 2022

update

✅ Branch has been successfully updated

@tavplubix tavplubix marked this pull request as draft June 17, 2022 15:50
@alexey-milovidov alexey-milovidov self-assigned this Jul 30, 2022
alexey-milovidov
alexey-milovidov approved these changes Jul 30, 2022
View reviewed changes
Copy link
Member

@alexey-milovidov alexey-milovidov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (if it works)

@kssenii
Copy link
Member Author

kssenii commented Aug 4, 2022 •
edited by alexey-milovidov
Loading

It works, but it is on always green mode now. Under tsan 0 tests failed, but under debug 7 tests failed.

Screenshot 2022-08-04 at 14 03 01

Screenshot 2022-08-04 at 14 03 16

@kssenii
Copy link
Member Author

kssenii commented Aug 4, 2022 •
edited by alexey-milovidov
Loading

test failures in debug do not look serious, I'll try to fix

01283_max_threads_simple_query_optimization
01524_do_not_merge_across_partitions_select_final
01323_too_many_threads_bug
00314_sample_factor_virtual_column
00090_union_race_conditions_1
02228_merge_tree_insert_memory_usage
02127_plus_before_float

@alexey-milovidov
Copy link
Member

We need this :)

@kssenii
Copy link
Member Author

kssenii commented Sep 5, 2022

👀 oh, zero tests failed

Screenshot 2022-09-05 at 16 13 14

Screenshot 2022-09-05 at 16 14 16

@kssenii kssenii marked this pull request as ready for review September 5, 2022 18:45
@alexey-milovidov
Copy link
Member

thread vs tsan in the check name.
Let's unify to tsan.

@alexey-milovidov alexey-milovidov merged commit b32c7e4 into ClickHouse:master Sep 5, 2022
@tavplubix tavplubix mentioned this pull request Sep 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexey-milovidov alexey-milovidov alexey-milovidov approved these changes

Assignees

@alexey-milovidov alexey-milovidov

Labels
pr-not-for-changelog This PR should not be mentioned in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kssenii @alesapin @alexey-milovidov @robot-clickhouse