Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not calculate integrals in statistical tests #36953

Merged
merged 6 commits into from
Jun 7, 2022

Conversation

nikitamikhaylov
Copy link
Member

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Do not calculate an integral numerically but use CDF functions instead. This will speed up execution and will increase the precision. This fixes #36714

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-improvement Pull request with some product improvements label May 5, 2022
@alexey-milovidov alexey-milovidov self-assigned this May 5, 2022
@nikitamikhaylov
Copy link
Member Author

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented May 19, 2022

update

☑️ Nothing to do

  • -closed [:pushpin: update requirement]
  • #commits-behind>0 [:pushpin: update requirement]

@nikitamikhaylov
Copy link
Member Author

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Jun 1, 2022

update

✅ Branch has been successfully updated

@nikitamikhaylov
Copy link
Member Author

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Jun 2, 2022

update

✅ Branch has been successfully updated

@nikitamikhaylov
Copy link
Member Author

Fuzzer issue will be fixed here: #37759

@nikitamikhaylov nikitamikhaylov merged commit 85a1204 into master Jun 7, 2022
@nikitamikhaylov nikitamikhaylov deleted the statistical-tests branch June 7, 2022 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-improvement Pull request with some product improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect pvalue in studentTTest
3 participants