Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
LC of nullable is not implemented. LC of nullable requires a null item at the first position of the collection, moving the default item to the second position. Since there is a null item at the beginning and all null items point to it, there is no need for a null map. Hence, the null map is not serialized.
The null map currently maintained by the Nullable column becomes invalid when it's inside a LC column. Because of that, the
nulls.size() == nested.size()
assertions were removed.The above was implemented by adding branching logic in multiple places inside LC column, which is complicated/ messy and error prone. This could be avoided by having a proper inheritance chain or using the pimpl idiom. The former was not implemented because we want to minimize the changes to the public API. The latter was not implemented because we have more important things on the roadmap and will be considered again in the near future.
Changes
nulls.size() == nested.size()
assertions inside ColumnNullable.Testing
Added unit tests and ran against a local instance.
Closes #76