#733 driver implemets the sql/driver/ConnBeginTx interface

[albertlockett]

#733

[jkaflik]

Hi @albertlockett

Thanks for submitting this PR.
Did you check if otelsql is able to support SQL drivers that do not implement ConnBeginTx interface? From our point of view, it makes more sense to keep our API away from fake doors.

[albertlockett]

@jkaflik I will check w/ otelsql maintainers and follow up. Do you think it makes sense though to implement ConnBeginTx as driver.Conn's Begin method is deprecated?
https://pkg.go.dev/database/sql/driver#Conn

[jkaflik]

@albertlockett thanks for giving me a reference. Indeed, it seems we should deprecate ConnBeginTx interface.
I think we can proceed with your PR. Can we experiment by removing Begin function?

[albertlockett]

We could experiment by removing the Begin function. I'm not sure if there are other reasons to keep it around for backwards compatibility?

Also, it looks like otelsql will begin supporting the driver.Conn interface if/when this PR merges:
XSAM/otelsql#153