Merge pull request #985 from subkanthi/fix_clickhousearrayvalue_Boolean

Fixes number cast exception for ClickHouseArrayValue with Boolean[]

Author: zhicwu

clickhouse-client/src/main/java/com/clickhouse/client/data/array/ClickHouseByteArrayValue.java

@@ -91,11 +91,19 @@ public Object[] asArray() {
     public <E> E[] asArray(Class<E> clazz) {
         byte[] v = getValue();
         int len = v.length;
-        E[] array = ClickHouseValues.createObjectArray(clazz, len, 1);
-        for (int i = 0; i < len; i++) {
-            array[i] = clazz.cast(v[i]);
+        if (clazz == Boolean.class) {
+            Boolean[] array = new Boolean[len];
+            for (int i = 0; i < len; i++) {
+                array[i] = v[i] == (byte) 1 ? Boolean.TRUE : Boolean.FALSE;
+            }
+            return (E[]) array;
+        } else {
+            E[] array = ClickHouseValues.createObjectArray(clazz, len, 1);
+            for (int i = 0; i < len; i++) {
+                array[i] = clazz.cast(v[i]);
+            }
+            return array;
         }
-        return array;
     }
 
     @Override
@@ -461,6 +469,12 @@ public ClickHouseByteArrayValue update(Object[] value) {
         int len = value == null ? 0 : value.length;
         if (len == 0) {
             return resetToNullOrEmpty();
+        } else if (value instanceof Boolean[]) {
+            byte[] values = new byte[len];
+            for (int i = 0; i < len; i++) {
+                values[i] = Boolean.TRUE.equals(value[i]) ? (byte) 1 : (byte) 0;
+            }
+            set(values);
         } else {
             byte[] values = new byte[len];
             for (int i = 0; i < len; i++) {

clickhouse-client/src/test/java/com/clickhouse/client/data/ClickHouseRowBinaryProcessorTest.java

@@ -175,6 +175,32 @@ public void testSerializeArray() throws IOException {
                         0x63, 0, 2, 1, 0));
     }
 
+    @Test(groups = { "unit" })
+    public void testSerializeBoolean() throws IOException {
+        ClickHouseConfig config = new ClickHouseConfig();
+
+        ClickHouseValue value = ClickHouseArrayValue.of(new Boolean[][] { new Boolean[] { true, false } });
+        ByteArrayOutputStream bas = new ByteArrayOutputStream();
+        ClickHouseOutputStream out = ClickHouseOutputStream.of(bas);
+        ClickHouseRowBinaryProcessor.getMappedFunctions().serialize(value, config,
+                ClickHouseColumn.of("a", "Array(Array(Boolean))"), out);
+        out.flush();
+        Assert.assertEquals(bas.toByteArray(), BinaryStreamUtilsTest.generateBytes(1, 2, 1, 0));
+
+        boolean[] nativeBoolArray = new boolean[3];
+        nativeBoolArray[0] = true;
+        nativeBoolArray[1] = false;
+        nativeBoolArray[2] = true;
+
+        ClickHouseValue value2 = ClickHouseArrayValue.of(new boolean[][]{nativeBoolArray});
+        ByteArrayOutputStream bas2 = new ByteArrayOutputStream();
+        ClickHouseOutputStream out2 = ClickHouseOutputStream.of(bas2);
+        ClickHouseRowBinaryProcessor.getMappedFunctions().serialize(value2, config,
+                ClickHouseColumn.of("a", "Array(Array(boolean))"), out2);
+        out2.flush();
+        Assert.assertEquals(bas2.toByteArray(), BinaryStreamUtilsTest.generateBytes(1, 3, 1, 0, 1));
+    }
+
     @Test(groups = { "unit" })
     public void testDeserializeMap() throws IOException {
         ClickHouseConfig config = new ClickHouseConfig();

clickhouse-client/src/test/java/com/clickhouse/client/data/array/ClickHouseByteArrayValueTest.java

@@ -0,0 +1,26 @@
+package com.clickhouse.client.data.array;
+
+import org.junit.Assert;
+import org.testng.annotations.Test;
+
+public class ClickHouseByteArrayValueTest {
+    @Test(groups = { "unit" })
+    public void testConvertToBoolean() throws Exception {
+        ClickHouseByteArrayValue v = ClickHouseByteArrayValue
+                .of(new byte[] { 0, 1, -1 });
+        Assert.assertArrayEquals(v.getValue(), new byte[] { 0, 1, -1 });
+        Assert.assertArrayEquals(v.asArray(Boolean.class), new Boolean[] { false, true, false });
+    }
+
+    @Test(groups = { "unit" })
+    public void testConvertFromBoolean() throws Exception {
+        ClickHouseByteArrayValue v = ClickHouseByteArrayValue.ofEmpty();
+        Assert.assertArrayEquals(v.getValue(), new byte[0]);
+        v.update(new boolean[] { false, true, false });
+        Assert.assertArrayEquals(v.getValue(), new byte[] { 0, 1, 0 });
+        v.resetToNullOrEmpty();
+        Assert.assertArrayEquals(v.getValue(), new byte[0]);
+        v.update(new Boolean[] { Boolean.FALSE, Boolean.FALSE, Boolean.TRUE });
+        Assert.assertArrayEquals(v.getValue(), new byte[] { 0, 0, 1 });
+    }
+}