Skip to content

Conversation

n-oden
Copy link
Contributor

@n-oden n-oden commented May 12, 2022

No description provided.

@CLAassistant
Copy link

CLAassistant commented May 12, 2022

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link

Benchmark                                (client)  (connection)  (statement)  (type)   Mode  Cnt     Score     Error  Units
Basic.insertOneRandomNumber  clickhouse-http-jdbc         reuse       normal  object  thrpt   20   242.820 ±  49.742  ops/s
Basic.insertOneRandomNumber  clickhouse-http-jdbc         reuse     prepared  object  thrpt   20   239.724 ±  29.110  ops/s
Basic.insertOneRandomNumber  clickhouse-http-jdbc           new       normal  object  thrpt   20   255.378 ±  20.975  ops/s
Basic.insertOneRandomNumber  clickhouse-http-jdbc           new     prepared  object  thrpt   20   225.238 ±  23.442  ops/s
Basic.insertOneRandomNumber  clickhouse-grpc-jdbc         reuse       normal  object  thrpt   20   252.226 ±  28.120  ops/s
Basic.insertOneRandomNumber  clickhouse-grpc-jdbc         reuse     prepared  object  thrpt   20   226.887 ±  22.421  ops/s
Basic.insertOneRandomNumber  clickhouse-grpc-jdbc           new       normal  object  thrpt   20   261.877 ±  35.896  ops/s
Basic.insertOneRandomNumber  clickhouse-grpc-jdbc           new     prepared  object  thrpt   20   222.524 ±  24.277  ops/s
Basic.selectOneRandomNumber  clickhouse-http-jdbc         reuse       normal  object  thrpt   20  1079.171 ± 110.772  ops/s
Basic.selectOneRandomNumber  clickhouse-http-jdbc         reuse     prepared  object  thrpt   20  1102.467 ± 115.620  ops/s
Basic.selectOneRandomNumber  clickhouse-http-jdbc           new       normal  object  thrpt   20  1063.417 ±  74.121  ops/s
Basic.selectOneRandomNumber  clickhouse-http-jdbc           new     prepared  object  thrpt   20  1138.450 ±  89.103  ops/s
Basic.selectOneRandomNumber  clickhouse-grpc-jdbc         reuse       normal  object  thrpt   20   900.906 ±  82.181  ops/s
Basic.selectOneRandomNumber  clickhouse-grpc-jdbc         reuse     prepared  object  thrpt   20   915.208 ±  51.078  ops/s
Basic.selectOneRandomNumber  clickhouse-grpc-jdbc           new       normal  object  thrpt   20   908.262 ±  77.713  ops/s
Basic.selectOneRandomNumber  clickhouse-grpc-jdbc           new     prepared  object  thrpt   20   961.716 ±  74.436  ops/s

@zhicwu zhicwu changed the base branch from master to develop May 12, 2022 22:11
@zhicwu
Copy link
Contributor

zhicwu commented May 12, 2022

Thanks @n-oden. I was waiting for Okhttp 3/4 support, so that we can add another implementation in clickhouse-http-client without outdated dependencies :) Could you also update third-party-libraries since grpc-java still does not support JPMS(even 1.46)?

By the way, is your work depending on the new version? FYI, it's probably not worthy of using gRPC with ClickHouse at this point due to the performance issue mentioned at here.

@n-oden
Copy link
Contributor Author

n-oden commented May 13, 2022

@zhicwu updated third-party-libraries

The context for this is fairly weird: we found that when we included clickhouse-jdbc as a dependency in our apache beam jobs, any use of several google cloud APIs would cause a JVM segfault and crash! As far as we could tell (also in consultation w/ altinity support) the issue was that the 1.40.1 version of grpc was including .so/dll files that were causing symbol resolution errors versus the more recent version transitively included by the google-cloud-foo dependencies.

@zhicwu
Copy link
Contributor

zhicwu commented May 14, 2022

I see. But why not use shaded jar instead?

Anyway, protobuf should be updated as well or the code generated by protoc won't work. I don't have privilege to update your branch so I'll fix that in a separate PR.

@zhicwu zhicwu merged commit bcd4028 into ClickHouse:develop May 14, 2022
@zhicwu zhicwu mentioned this pull request May 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants