-
Notifications
You must be signed in to change notification settings - Fork 608
update grpc to 1.45.1 #936
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
merge 0.3.2-patch8
Merge patch9
|
Thanks @n-oden. I was waiting for Okhttp 3/4 support, so that we can add another implementation in By the way, is your work depending on the new version? FYI, it's probably not worthy of using gRPC with ClickHouse at this point due to the performance issue mentioned at here. |
@zhicwu updated third-party-libraries The context for this is fairly weird: we found that when we included clickhouse-jdbc as a dependency in our apache beam jobs, any use of several google cloud APIs would cause a JVM segfault and crash! As far as we could tell (also in consultation w/ altinity support) the issue was that the 1.40.1 version of grpc was including .so/dll files that were causing symbol resolution errors versus the more recent version transitively included by the google-cloud-foo dependencies. |
I see. But why not use shaded jar instead? Anyway, protobuf should be updated as well or the code generated by protoc won't work. I don't have privilege to update your branch so I'll fix that in a separate PR. |
No description provided.