Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tests, add more socket and ping tests, re-export a bit more types, add a coverage badge #256

Merged
merged 2 commits into from
Mar 30, 2024
Merged

Update tests, add more socket and ping tests, re-export a bit more types, add a coverage badge #256

merged 2 commits into from
Mar 30, 2024

Conversation

slvrtrn
Copy link
Contributor

@slvrtrn slvrtrn commented Mar 30, 2024

Summary

  • Changed the test Cloud instance wake-up function a bit.
  • Added more tests for socket timeouts while debugging to figure out if it is an issue with ping or not (it is not).
  • Re-exported more useful types from common.
  • Added a coverage badge. It is, unfortunately, grey even with 94%.

Checklist

  • Unit and integration tests covering the common scenarios were added

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 30, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@slvrtrn slvrtrn merged commit f0e99b4 into main Mar 30, 2024
57 checks passed
@slvrtrn slvrtrn deleted the update-tests-and-exports branch March 30, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@slvrtrn