Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix URL configuration with the default HTTP/HTTPS ports #259

Merged
merged 2 commits into from
Apr 2, 2024

Conversation

slvrtrn
Copy link
Contributor

@slvrtrn slvrtrn commented Apr 2, 2024

Summary

Resolves #258.
Completely overlooked this one (and the unit test for the offending part was entirely wrong).

Checklist

  • Unit and integration tests covering the common scenarios were added
  • A human-readable description of the changes was provided to include in CHANGELOG

Copy link

sonarcloud bot commented Apr 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@slvrtrn slvrtrn merged commit 720ca1b into main Apr 2, 2024
29 checks passed
@slvrtrn slvrtrn deleted the fix-default-http-https-ports branch April 2, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

createClient doesn't work with URL on port 80 or 443 since 1.0.0
1 participant