Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Curator Form mechanism #29

Closed
forresttanaka opened this issue Jun 18, 2015 · 3 comments
Closed

Make Curator Form mechanism #29

forresttanaka opened this issue Jun 18, 2015 · 3 comments
Assignees
@forresttanaka

Comments

@forresttanaka
Copy link
Contributor

Now that the Curator demo page is done, come up with a way to make pages similar to this that we can use in production, not the hacked up way I’ve done it so far.
@forresttanaka forresttanaka self-assigned this Jun 18, 2015
This was referenced Jun 19, 2015
Closed
Closed
forresttanaka added a commit that referenced this issue Jun 19, 2015
@forresttanaka
Enable Persona login system
7531edc 
This is just temporary until I finish up styling and navigation refactoring with Issue #29.
This was referenced Jun 19, 2015
Closed
Merged
@forresttanaka
Copy link
Contributor Author

As I’m starting to confuse myself, these are the target goals for this ticket:

  • Curator pages as their own schema
  • Refactored navigation React components
  • Secondary navigation for Persona login/logout
  • Style non-curator pages, primarily the JSON ones, for 0.1 presentation.

kilodalton added a commit that referenced this issue Jun 22, 2015
@kilodalton
Merge pull request #36 from ClinGen/29_ft_curator_form_schema
ac59512 
Connects to #29 Curator form schema etc.
@kilodalton kilodalton mentioned this issue Jun 22, 2015
Merged
kilodalton added a commit that referenced this issue Jun 22, 2015
@kilodalton
Revert "Connects to #29 Curator form schema etc."
603c4bb
kilodalton added a commit that referenced this issue Jun 22, 2015
@kilodalton
Merge pull request #39 from ClinGen/revert-36-29_ft_curator_form_schema
635fcc7 
Revert "Connects to #29 Curator form schema etc."
kilodalton added a commit that referenced this issue Jun 22, 2015
@kilodalton
Revert "Revert "Connects to #29 Curator form schema etc.""
7cc731a
@forresttanaka forresttanaka mentioned this issue Jun 22, 2015
Closed
@forresttanaka forresttanaka self-assigned this Jun 23, 2015
@kilodalton
Copy link
Contributor

Looks great.

image

kilodalton added a commit that referenced this issue Jun 23, 2015
@kilodalton
Merge pull request #44 from ClinGen/29_ft_curator_page
c729232 
Connects to #29 Curator page styling
@kilodalton kilodalton mentioned this issue Jun 23, 2015
Merged
@kilodalton
Copy link
Contributor

Great job. Thanks for all your hard work to get the app to production!

@kilodalton kilodalton removed the merged label Nov 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@forresttanaka forresttanaka

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@forresttanaka @kilodalton