-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/dragen cli #873
Feature/dragen cli #873
Conversation
- Moved write_toml_config to separate pm - Added test for toml
…mics/MIP into feature/dragen_cli
Ordered subs AB
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to see that dragen is starting to happen. I think it looks good and we will know more about how it runs once dragen is actually installed
# - cd /lib/x86_64-linux-gnu | ||
# - sudo ln -s libssl.so.1.0.0 libssl.so.10 | ||
# - sudo ln -s libcrypto.so.1.0.0 libcrypto.so.10 | ||
# - cd - | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice to clean up the travis file a bit 🏗️
update_path: absolute_path | ||
picardtools_path: | ||
associated_recipe: | ||
# - dragen_dna |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No I left these comments intentionally to be activated once we actually have a dragen to interact with.
outfile_suffix: ".vcf" | ||
# program_executables: | ||
# - dragen | ||
type: recipe |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove?
Or is this something that will be activated once dragen is actually installed?
@@ -165,27 +165,13 @@ sv_vcfanno: | |||
data_type: SCALAR | |||
default: 0 | |||
type: recipe_argument |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What separates this file from dragen_rd_dna_parameters.yaml?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder how that got there! I will remove it
active_parameter_href => $active_parameter_href, | ||
file_info_href => $file_info_href, | ||
parameter_href => $parameter_href, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to see that there still are some parameters that can be ordered AB ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😄
This PR fixes:
How to test:
Expected outcome:
Review: