Feature/dragen cli #873
Merged
Feature/dragen cli #873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Moved write_toml_config to separate pm - Added test for toml
…mics/MIP into feature/dragen_cli
Ordered subs AB
jemten
reviewed
Jun 20, 2019
| # - cd /lib/x86_64-linux-gnu | ||
| # - sudo ln -s libssl.so.1.0.0 libssl.so.10 | ||
| # - sudo ln -s libcrypto.so.1.0.0 libcrypto.so.10 | ||
| # - cd - | ||
|
|
There was a problem hiding this comment.
Nice to clean up the travis file a bit 🏗️
| update_path: absolute_path | ||
| picardtools_path: | ||
| associated_recipe: | ||
| # - dragen_dna |
There was a problem hiding this comment.
No I left these comments intentionally to be activated once we actually have a dragen to interact with.
| outfile_suffix: ".vcf" | ||
| # program_executables: | ||
| # - dragen | ||
| type: recipe |
There was a problem hiding this comment.
Remove?
Or is this something that will be activated once dragen is actually installed?
| @@ -165,27 +165,13 @@ sv_vcfanno: | |||
| data_type: SCALAR | |||
| default: 0 | |||
| type: recipe_argument | |||
There was a problem hiding this comment.
What separates this file from dragen_rd_dna_parameters.yaml?
There was a problem hiding this comment.
I wonder how that got there! I will remove it
| active_parameter_href => $active_parameter_href, | ||
| file_info_href => $file_info_href, | ||
| parameter_href => $parameter_href, |
There was a problem hiding this comment.
Good to see that there still are some parameters that can be ordered AB ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes:
How to test:
Expected outcome:
Review: