Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve landing page #204

Merged
merged 5 commits into from
Mar 17, 2022
Merged

Improve landing page #204

merged 5 commits into from
Mar 17, 2022

Conversation

northwestwitch
Copy link
Member

@northwestwitch northwestwitch commented Mar 17, 2022

This PR adds | fixes:

How to prepare for test:

  • Install on cg-v1 and check that the above things work as intended

Review:

  • Code approved by
  • Tests executed by CR
  • "Merge and deploy" approved by

This version is a:

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

@codecov
Copy link

codecov bot commented Mar 17, 2022

Codecov Report

Merging #204 (a441673) into main (75a88ee) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #204   +/-   ##
=======================================
  Coverage   95.46%   95.47%           
=======================================
  Files          57       57           
  Lines        2582     2583    +1     
=======================================
+ Hits         2465     2466    +1     
  Misses        117      117           
Flag Coverage Δ
unittests 95.47% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cgbeacon2/server/blueprints/api_v1/controllers.py 97.33% <ø> (ø)
cgbeacon2/server/blueprints/api_v1/views.py 99.18% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cbbe6c...a441673. Read the comment docs.

@northwestwitch
Copy link
Member Author

northwestwitch commented Mar 17, 2022

  • Check that / endpount returns json info: 🆗

image

  • Check that 0-based coords tooltips work: 🆗

image

  • Check that dataset info modal works: 🆗

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expand description of datasets on landing page
1 participant