Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force API to create dataset version of type string #241

Merged
merged 3 commits into from
May 20, 2022

Conversation

northwestwitch
Copy link
Member

@northwestwitch northwestwitch commented May 20, 2022

This PR adds | fixes:

  • Make sure that dataset saved into database contain a version value of type string

How to prepare for test:

  • Run demo server

How to test:

  • Send a request to add a dataset with version value of type int

Expected outcome:

  • The dataset should be saved with type str

Review:

  • Code approved by
  • Tests executed by CR
  • "Merge and deploy" approved by

This version is a:

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

@codecov
Copy link

codecov bot commented May 20, 2022

Codecov Report

Merging #241 (c479d5d) into main (854817c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #241   +/-   ##
=======================================
  Coverage   95.14%   95.14%           
=======================================
  Files          56       56           
  Lines        2616     2617    +1     
=======================================
+ Hits         2489     2490    +1     
  Misses        127      127           
Flag Coverage Δ
unittests 95.14% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cgbeacon2/server/blueprints/api_v1/views.py 98.70% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd333b8...c479d5d. Read the comment docs.

@northwestwitch
Copy link
Member Author

Tested 🆗

image

image

@northwestwitch northwestwitch merged commit 4b09d35 into main May 20, 2022
@northwestwitch northwestwitch deleted the dataset_string_version branch May 20, 2022 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant