Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated GitHub actions #254

Merged
merged 1 commit into from
May 13, 2024
Merged

Updated GitHub actions #254

merged 1 commit into from
May 13, 2024

Conversation

northwestwitch
Copy link
Member

@northwestwitch northwestwitch commented May 13, 2024 •
edited

This PR adds | fixes:

  • Updated some old version of GitHib actions

How to test:

  • AUtomatic tests

Expected outcome:

  • All automatic tests should pass

Review:

  • Code approved by
  • Tests executed by GitHub actions

This version is a:

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

@northwestwitch northwestwitch marked this pull request as ready for review May 13, 2024 11:57
dnil
dnil approved these changes May 13, 2024
View reviewed changes
.github/workflows/deploy_mkdocs.yml
- name: Setup environment for docs deployment
uses: actions/setup-python@v2
uses: actions/setup-python@v5
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

.github/workflows/pypi_build_n_publish.yml
with:
python-version: 3.7
python-version: 3.8
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

.github/workflows/pytest_n_coveralls.yml
with:
python-version: 3.7
python-version: 3.8
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@northwestwitch northwestwitch merged commit 2fed733 into master May 13, 2024
1 check passed
@northwestwitch northwestwitch deleted the update_actions branch May 13, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnil dnil dnil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@northwestwitch @dnil