Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix enum spelling #296

Merged
merged 4 commits into from
Nov 10, 2023
Merged

Fix enum spelling #296

merged 4 commits into from
Nov 10, 2023

Conversation

seallard
Copy link
Contributor

@seallard seallard commented Nov 6, 2023 •
edited
Loading

Description

First step of resolving #239. This PR fixes the spelling of the analysis.status enum field canceled to cancelled.

Worst case, a status will change color in cigrid-ui after this patch from what I understand.

Fixed

  • Change spelling of enum field
  • Add revision for the change to reflect it in the database

Testing

Applied revision to stage, looks ok.

This version is a

  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

@seallard seallard marked this pull request as ready for review November 7, 2023 15:11
@seallard seallard requested a review from a team as a code owner November 7, 2023 15:11
islean
islean approved these changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@islean islean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks beautiful!

@seallard seallard requested a review from fevac November 7, 2023 15:53
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@seallard seallard merged commit 4d51376 into master Nov 10, 2023
6 checks passed
@seallard seallard deleted the fix-enum-spelling branch November 10, 2023 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@islean islean islean approved these changes

@fevac fevac Awaiting requested review from fevac

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seallard @islean