-
Notifications
You must be signed in to change notification settings - Fork 786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unit tests for Submission worker. #2336
Conversation
@RishabhJain2018 The command I used to run the tests: |
@KhalidRmb were you able to resolve the issue with |
@Ram81 No, I've done a corrupt file check as specified in the zipfile docs, but they pass. Rishabh is looking into it I think. |
@KhalidRmb why are the travis build failing can you fix that? if it is a blocker let's add that test later on. For now just add the tests that are working |
Use this command for running the tests, to avoid travis errors. A new PR is required to change the env variable DJANGO_SERVER to testserver in test environment. |
@KhalidRmb please remove the failing tests on which you are blocked, so that we can merge rest of the PR |
Done @Ram81 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@KhalidRmb @RishabhJain2018 LGTM 👍
Following tests are covered:
download_and_extract_file
download_and_extract_zip_file
create_dir
create_dir_as_python_package
return_file_per_environment
get_or_create_sqs_queue