Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit tests for remote_submission_worker. #2350

Merged
merged 10 commits into from
Jul 20, 2019
Merged

Unit tests for remote_submission_worker. #2350

merged 10 commits into from
Jul 20, 2019

Conversation

KhalidRmb
Copy link
Member

@KhalidRmb KhalidRmb commented May 30, 2019 •
edited
Loading

12 test cases for remote_submission_worker.

@KhalidRmb
Copy link
Member Author

@Ram81 @RishabhJain2018 Please take a look.

@Ram81
Copy link
Member

Ram81 commented May 31, 2019

@KhalidRmb can you check why the travis build is failing

Ram81
Ram81 requested changes Jun 2, 2019
View reviewed changes
Copy link
Member

@Ram81 Ram81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KhalidRmb can you organise the tests in multiple classes like we did it here https://github.com/Cloud-CV/EvalAI/blob/master/tests/unit/challenges/test_views.py

@RishabhJain2018 your inputs

@KhalidRmb
Copy link
Member Author

KhalidRmb commented Jun 2, 2019 •
edited
Loading

@KhalidRmb can you organise the tests in multiple classes like we did it here https://github.com/Cloud-CV/EvalAI/blob/master/tests/unit/challenges/test_views.py

Sure, a class for each type of method. I'll do that.

@KhalidRmb
Copy link
Member Author

@Ram81 Please review.

Ram81
Ram81 requested changes Jun 8, 2019
View reviewed changes
Copy link
Member

@Ram81 Ram81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KhalidRmb please restructure the test file with one base class with common attributes and all other subclasses

Ram81
Ram81 requested changes Jun 8, 2019
View reviewed changes
Copy link
Member

@Ram81 Ram81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KhalidRmb have a look at https://github.com/Cloud-CV/EvalAI/blob/master/tests/unit/challenges/test_views.py and please make the changes to avoid redundacy in code

tests/unit/remoteworker/test_remote_worker.py Outdated Show resolved Hide resolved
tests/unit/remoteworker/test_remote_worker.py Show resolved Hide resolved
@Ram81
Copy link
Member

Ram81 commented Jun 12, 2019

@RishabhJain2018 other than the get methods part rest of the PR LGTM 👍

@Ram81
Copy link
Member

Ram81 commented Jun 25, 2019

@KhalidRmb please add the get methods for URLs and we are good to go for this PR

@KhalidRmb
Copy link
Member Author

KhalidRmb commented Jun 26, 2019 •
edited
Loading

@KhalidRmb please add the get methods for URLs and we are good to go for this PR

Done. @Ram81

Ram81
Ram81 approved these changes Jul 1, 2019
View reviewed changes
Copy link
Member

@Ram81 Ram81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KhalidRmb @RishabhJain2018 LGTM 👍

@RishabhJain2018 RishabhJain2018 merged commit 89560d9 into Cloud-CV:master Jul 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ram81 Ram81 Ram81 approved these changes

@RishabhJain2018 RishabhJain2018 RishabhJain2018 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KhalidRmb @Ram81 @RishabhJain2018