Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration tests for Submisison worker. #2352

Merged
merged 16 commits into from
Jul 8, 2019
Merged

Integration tests for Submisison worker. #2352

merged 16 commits into from
Jul 8, 2019

Conversation

KhalidRmb
Copy link
Member

@KhalidRmb KhalidRmb commented May 31, 2019 •
edited
Loading

Add integration tests for the submission worker. The following are covered:

1. process_submission_callback
2. process_submission_message
3. extract_submission_data
4. extract_challenge_data
5. run_submission

@KhalidRmb
Copy link
Member Author

@RishabhJain2018 @Ram81 Please have a look.

@Ram81
Copy link
Member

Ram81 commented Jun 3, 2019

@KhalidRmb can you fix the flake 8 issues & are the other tests not complete yet?

@KhalidRmb
Copy link
Member Author

@Ram81 I've removed the blockers for debugging later as we'd discussed. PTAL.

Ram81
Ram81 reviewed Jul 1, 2019
View reviewed changes
Copy link
Member

@Ram81 Ram81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KhalidRmb some minor changes

tests/integration/submissionworker/test_submission_worker.py Outdated Show resolved Hide resolved
tests/integration/submissionworker/test_submission_worker.py Outdated Show resolved Hide resolved
tests/integration/submissionworker/test_submission_worker.py Outdated Show resolved Hide resolved
@RishabhJain2018
Copy link
Member

@KhalidRmb As a general note, please add the description to the PR's.

RishabhJain2018
RishabhJain2018 requested changes Jul 4, 2019
View reviewed changes
tests/integration/worker/test_submission_worker.py Outdated Show resolved Hide resolved
tests/integration/worker/test_submission_worker.py Outdated Show resolved Hide resolved
tests/integration/worker/test_submission_worker.py Outdated Show resolved Hide resolved
tests/integration/worker/test_submission_worker.py Outdated Show resolved Hide resolved
tests/integration/worker/test_submission_worker.py Outdated Show resolved Hide resolved
tests/integration/worker/test_submission_worker.py Outdated Show resolved Hide resolved
tests/integration/worker/test_submission_worker.py Outdated Show resolved Hide resolved
tests/integration/worker/test_submission_worker.py Outdated Show resolved Hide resolved
tests/integration/worker/test_submission_worker.py Outdated Show resolved Hide resolved
RishabhJain2018
RishabhJain2018 requested changes Jul 5, 2019
View reviewed changes
tests/integration/worker/test_submission_worker.py Show resolved Hide resolved
tests/integration/worker/test_submission_worker.py Outdated Show resolved Hide resolved
tests/integration/worker/test_submission_worker.py Outdated Show resolved Hide resolved
tests/integration/worker/test_submission_worker.py Outdated Show resolved Hide resolved
tests/integration/worker/test_submission_worker.py Outdated Show resolved Hide resolved
tests/integration/worker/test_submission_worker.py Outdated Show resolved Hide resolved
tests/integration/worker/test_submission_worker.py Outdated Show resolved Hide resolved
tests/integration/worker/test_submission_worker.py Outdated Show resolved Hide resolved
tests/integration/worker/test_submission_worker.py Show resolved Hide resolved
tests/integration/worker/test_submission_worker.py Outdated Show resolved Hide resolved
@KhalidRmb
Copy link
Member Author

@RishabhJain2018 Have made the changes. The rest changes of id->pk have to be made after the submission worker is changed (another PR). PTAL.

@RishabhJain2018 RishabhJain2018 merged commit b5f22a3 into Cloud-CV:master Jul 8, 2019
KhalidRmb added a commit to KhalidRmb/EvalAI that referenced this pull request Jul 17, 2019
@KhalidRmb
Worker: Add Integration tests for submission worker(Cloud-CV#2352)
98ada16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ram81 Ram81 Ram81 left review comments

@RishabhJain2018 RishabhJain2018 RishabhJain2018 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KhalidRmb @Ram81 @RishabhJain2018