Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add frontend, backend & test for Resend Email feature with throttling. #2401

Closed
wants to merge 4 commits into from

Conversation

KhalidRmb
Copy link
Member

The user can now resend the verification email upto 3 times per hour.
Screenshot from 2019-07-21 18-56-30
Screenshot from 2019-07-21 18-57-56
Screenshot from 2019-07-21 18-58-20

@KhalidRmb
Copy link
Member Author

@Ram81 @RishabhJain2018 PTAL.

@stale
Copy link

stale bot commented Sep 19, 2019

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the inactivity label Sep 19, 2019
@stale stale bot removed the inactivity label Sep 19, 2019
@stale
Copy link

stale bot commented Dec 27, 2019

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the inactivity label Dec 27, 2019
@stale
Copy link

stale bot commented Jan 3, 2020

This pull request has been automatically closed as there is no further activity. Thank you for your contributions.

@stale stale bot closed this Jan 3, 2020
@stale stale bot removed the inactivity label Jan 3, 2020
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@f59eca2). Click here to learn what that means.
The diff coverage is 44.44%.

@@            Coverage Diff            @@
##             master    #2401   +/-   ##
=========================================
  Coverage          ?   73.05%           
=========================================
  Files             ?       83           
  Lines             ?     5363           
  Branches          ?        0           
=========================================
  Hits              ?     3918           
  Misses            ?     1445           
  Partials          ?        0
Impacted Files Coverage Δ
settings/test.py 100% <ø> (ø)
settings/common.py 100% <ø> (ø)
apps/accounts/urls.py 100% <ø> (ø)
frontend/src/js/controllers/permissionCtrl.js 36.36% <22.22%> (ø)
apps/accounts/throttles.py 88.88% <88.88%> (ø)
Impacted Files Coverage Δ
settings/test.py 100% <ø> (ø)
settings/common.py 100% <ø> (ø)
apps/accounts/urls.py 100% <ø> (ø)
frontend/src/js/controllers/permissionCtrl.js 36.36% <22.22%> (ø)
apps/accounts/throttles.py 88.88% <88.88%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f59eca2...b23e053. Read the comment docs.

@stale
Copy link

stale bot commented Mar 3, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the inactivity label Mar 3, 2020
@stale
Copy link

stale bot commented Mar 10, 2020

This pull request has been automatically closed as there is no further activity. Thank you for your contributions.

@stale stale bot closed this Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants