-
Notifications
You must be signed in to change notification settings - Fork 786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add feature to start worker and notify host on challenge approval. #2807
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2807 +/- ##
==========================================
+ Coverage 72.93% 75.75% +2.82%
==========================================
Files 83 20 -63
Lines 5368 2924 -2444
==========================================
- Hits 3915 2215 -1700
+ Misses 1453 709 -744
Continue to review full report at Codecov.
|
Generally looks good to me. @Ram81 lets get this merged if your comments are incorporated. |
@KhalidRmb for now we can use |
Hey @Ram81 Can you please test this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@KhalidRmb Minor change. Let me know once you verify the case for notification signal for the unapproval case too. Rest of it LGTM
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 . Can you just share a screenshot of email template for any challenge. I didn't have aws dev & sendgrid credentials so couldn't test it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @KhalidRmb, Can you please fix the Travis build here: https://travis-ci.org/github/Cloud-CV/EvalAI/builds/697538429#L244
@KhalidRmb Can you please fix the travis build here? |
Done! |
@KhalidRmb Can you please resolve the conflicts here. |
Done, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor change. Rest of it LGTM 👍
@KhalidRmb Please resolve the conflicts here. |
@KhalidRmb Please fix the build here. |
Pending: