Add feature to display logs on UI #2862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KhalidRmb
changed the title
|
Ram81
requested changes
Jun 23, 2020
KhalidRmb
changed the title
Ram81
requested changes
Jun 27, 2020
There was a problem hiding this comment.
@KhalidRmb can you fix the failing tests so that I can test this one
Ram81
requested changes
Jun 27, 2020
|
@KhalidRmb Please resolve the conflicts here. |
RishabhJain2018
requested changes
Jun 28, 2020
| @@ -74,6 +75,8 @@ | |||
| vm.isChallengeLeaderboardPrivate = false; | |||
| vm.previousPublicSubmissionId = null; | |||
|
|
|||
| vm.worker_logs = [] | |||
There was a problem hiding this comment.
Can we please use CamelCase here.
|
Also, @KhalidRmb I feel when you commit code it is not autoformatted by black. Can you please check if you have the hook installed in your repository. |
RishabhJain2018
requested changes
Jun 28, 2020
RishabhJain2018
requested changes
Jun 28, 2020
RishabhJain2018
approved these changes
Jun 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Ram81 @RishabhJain2018 @deshraj