Send logs from Django, Celery & NodeJS containers to Cloudwatch. #2863
Conversation
There was a problem hiding this comment.
LGTM 👍 . Need to test this on staging once @RishabhJain2018
docker-compose-production.yml
Outdated
| driver: awslogs | ||
| options: | ||
| awslogs-region: ${AWS_DEFAULT_REGION} | ||
| awslogs-group: "django_production" |
There was a problem hiding this comment.
I think we also need to add this option here: https://docs.docker.com/config/containers/logging/awslogs/#awslogs-create-group
Same for all below options
There was a problem hiding this comment.
I've created those log groups on AWS, since it's not dynamic. We don't need the option here.
There was a problem hiding this comment.
But what if someone forks EvalAI and tries to deploy in the production setting or we change our AWS account then we will have to create them manually. What is the issue in adding this option?
There was a problem hiding this comment.
Right, I didn't realize that. I'll add the option.
|
@RishabhJain2018 Let's get this merged? |
@deshraj @Ram81 @RishabhJain2018
https://docs.docker.com/config/containers/logging/awslogs/