Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3935 Warn users that their tokens have expired. #4297

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

Harshit28j
Copy link

@Harshit28j Harshit28j commented Mar 13, 2024

This PR resolves #3935

image

@Harshit28j
Copy link
Author

Harshit28j commented Mar 14, 2024

@Suryansh5545 @gautamjajoo @gchhablani
I have come up with two approaches to resolve this issue.

please review and let me know

@codecov-commenter
Copy link

codecov-commenter commented Mar 14, 2024

Codecov Report

Merging #4297 (5831fc9) into master (96968d6) will decrease coverage by 3.62%.
Report is 1101 commits behind head on master.
The diff coverage is 80.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4297      +/-   ##
==========================================
- Coverage   72.93%   69.32%   -3.62%     
==========================================
  Files          83       20      -63     
  Lines        5368     3579    -1789     
==========================================
- Hits         3915     2481    -1434     
+ Misses       1453     1098     -355     
Files Coverage Δ
frontend/src/js/controllers/profileCtrl.js 66.82% <80.00%> (-26.04%) ⬇️

... and 64 files with indirect coverage changes

Files Coverage Δ
frontend/src/js/controllers/profileCtrl.js 66.82% <80.00%> (-26.04%) ⬇️

... and 64 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bacbf89...5831fc9. Read the comment docs.

Copy link
Member

@Suryansh5545 Suryansh5545 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. But I was thinking maybe we should prompt the user with a dialog instead and the dialog should have two buttons. The button to dismiss and refresh the token. What do you think @gchhablani ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warn users that their tokens have expired
3 participants