-
Notifications
You must be signed in to change notification settings - Fork 785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #3935 Warn users that their tokens have expired. #4297
base: master
Are you sure you want to change the base?
Conversation
@Suryansh5545 @gautamjajoo @gchhablani please review and let me know |
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #4297 +/- ##
==========================================
- Coverage 72.93% 69.32% -3.62%
==========================================
Files 83 20 -63
Lines 5368 3579 -1789
==========================================
- Hits 3915 2481 -1434
+ Misses 1453 1098 -355
... and 64 files with indirect coverage changes
... and 64 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. But I was thinking maybe we should prompt the user with a dialog instead and the dialog should have two buttons. The button to dismiss and refresh the token. What do you think @gchhablani ?
This PR resolves #3935