Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Added CoCo caption model to demonstrate use of LSTM layer (#115) #120

Closed
wants to merge 2 commits into from

Conversation

Ram81
Copy link
Member

@Ram81 Ram81 commented Sep 29, 2017

@dexter1691 Fixed 👍

@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.754% when pulling 7d8e2e2 on Ram81:COCO-Caption into 4d3a1c8 on Cloud-CV:master.

@Ram81
Copy link
Member Author

Ram81 commented Sep 29, 2017

model
Here's how model looks when loaded @utsavgarg

@virajprabhu
Copy link
Contributor

@Ram81 A bit part of Fabrik is being able to visualize models clearly. Can we try to have a better looking visualization?

@Ram81
Copy link
Member Author

Ram81 commented Sep 29, 2017

@virajprabhu I tried changing it this is the best I could do, can you suggest how do I change it so that it can be visualized better?

@virajprabhu
Copy link
Contributor

@utsavgarg You had generated good visualizations for some pretty complex models - can you guide @Ram81 ?

@Ram81 Ram81 changed the title Fix: Added CoCo caption model to deonstrate use of LSTM layer (#115) Fix: Added CoCo caption model to demonstrate use of LSTM layer (#115) Sep 30, 2017
@utsavgarg
Copy link
Contributor

@Ram81 try thinking of it like this --> start from the deepest child node and try to make all of its parents fall at the same level. I am not sure it will work for all cases but should be alright. Let me know if you have troubles implementing it, I'll give it a try.

@utsavgarg
Copy link
Contributor

@virajprabhu @Ram81 I saw the visualization problem in more detail. I don't think there is a problem with the algo which decides the position, but the problem is coming when the top and bottom names of a layer are same and there are layers connected differently in different phases (train, test). After simplifying these issues in the prototxt the visualization seems to be working fine. Thought this might help you solve the problem.
image

@Ram81
Copy link
Member Author

Ram81 commented Oct 3, 2017

@utsavgarg Thank You very much. I understood I'll do the required changes & update the PR

@Ram81
Copy link
Member Author

Ram81 commented Oct 3, 2017

@utsavgarg @virajprabhu I updated the model please review
train
Train Model
test
Test Model

@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.754% when pulling db556f8 on Ram81:COCO-Caption into 4d3a1c8 on Cloud-CV:master.

@utsavgarg
Copy link
Contributor

@Ram81 maybe I didn't explain properly, but I did not want you to change the prototxt to fit in the current visualization but rather the implementation to handle such prototxt files. In my last comment I was trying to explain why the visualization was failing, so please have a look at that.

@Ram81
Copy link
Member Author

Ram81 commented Oct 4, 2017

@utsavgarg I opened a issue for same.

@utsavgarg
Copy link
Contributor

@Ram81 closing this. Please submit another one after #127 is resolved.

@utsavgarg utsavgarg closed this Oct 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants