-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Added CoCo caption model to demonstrate use of LSTM layer (#115) #120
Conversation
|
@Ram81 A bit part of Fabrik is being able to visualize models clearly. Can we try to have a better looking visualization? |
@virajprabhu I tried changing it this is the best I could do, can you suggest how do I change it so that it can be visualized better? |
@utsavgarg You had generated good visualizations for some pretty complex models - can you guide @Ram81 ? |
@Ram81 try thinking of it like this --> start from the deepest child node and try to make all of its parents fall at the same level. I am not sure it will work for all cases but should be alright. Let me know if you have troubles implementing it, I'll give it a try. |
@virajprabhu @Ram81 I saw the visualization problem in more detail. I don't think there is a problem with the algo which decides the position, but the problem is coming when the top and bottom names of a layer are same and there are layers connected differently in different phases (train, test). After simplifying these issues in the prototxt the visualization seems to be working fine. Thought this might help you solve the problem. |
@utsavgarg Thank You very much. I understood I'll do the required changes & update the PR |
@utsavgarg @virajprabhu I updated the model please review |
@Ram81 maybe I didn't explain properly, but I did not want you to change the |
@utsavgarg I opened a issue for same. |
@dexter1691 Fixed 👍