Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #130: Created docker configuration with all requirements fulfilled #172

Closed
wants to merge 3 commits into from

Conversation

PalashTanejaPro
Copy link
Contributor

@PalashTanejaPro PalashTanejaPro commented Dec 8, 2017

@deshraj had asked to create a docker setup that fulfilled the following requirements:

  • Different containers for Postgres, NodeJS and Django
  • Add instructions in README
  • Environment variables
  • Separate /docker directory

I have done just that and have also used a precompiled caffe container to reduce installation time drastically.

The setup is also a very simple one-liner.

Please review @utsavgarg @virajprabhu

@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.715% when pulling a4b267f on PalashTanejaPro:clean_branch into 9378407 on Cloud-CV:master.

@PalashTanejaPro PalashTanejaPro mentioned this pull request Dec 8, 2017
2 tasks
@deshraj
Copy link
Member

deshraj commented Dec 8, 2017

@PalashTanejaPro thanks for the pull request. I will test this soon and will let you know.

@trexdinosaur
Copy link

hi, @PalashTanejaPro I'm getting this error while installing:
Django_1 | File "/code/manage.py", line 10, in
Django_1 | execute_from_command_line(sys.argv)
Django_1 | File "/usr/local/lib/python2.7/dist-packages/django/core/management/init.py", line 353, in execute_from_command_line
Django_1 | utility.execute()
Django_1 | File "/usr/local/lib/python2.7/dist-packages/django/core/management/init.py", line 302, in execute
Django_1 | settings.INSTALLED_APPS
Django_1 | File "/usr/local/lib/python2.7/dist-packages/django/conf/init.py", line 55, in getattr
Django_1 | self._setup(name)
Django_1 | File "/usr/local/lib/python2.7/dist-packages/django/conf/init.py", line 43, in _setup
Django_1 | self._wrapped = Settings(settings_module)
Django_1 | File "/usr/local/lib/python2.7/dist-packages/django/conf/init.py", line 99, in init
Django_1 | mod = importlib.import_module(self.SETTINGS_MODULE)
Django_1 | File "/usr/lib/python2.7/importlib/init.py", line 37, in import_module
Django_1 | import(name)
Django_1 | ImportError: No module named docker_settings

@coveralls
Copy link

Coverage Status

Coverage increased (+0.009%) to 96.724% when pulling 85385fb on PalashTanejaPro:clean_branch into 9378407 on Cloud-CV:master.

@PalashTanejaPro
Copy link
Contributor Author

@trexdinosaur The problem that you mentioned was fixed in my latest commit.

@deshraj
Copy link
Member

deshraj commented Feb 28, 2018

Sorry @PalashTanejaPro, there seems to be a lot of errors in the Pull Request and it doesn't seem to work for me.

@deshraj
Copy link
Member

deshraj commented Feb 28, 2018

If you are still interested in working on this issue, please feel free to checkout this branch https://github.com/Cloud-CV/Fabrik/tree/docker-fix and work on it. It seems to work pretty well. The only thing left in this code is that webpack is not installed properly. It would be good if someone can take lead on this since I am not able to find time to fix it.

@thatbrguy
Copy link
Contributor

@utsavgarg @deshraj Do you mind if I take this up? Keras backend has been changed to TF so we'll have to account for the extra dependencies now. I'd like to give it a shot

@Ram81
Copy link
Member

Ram81 commented Sep 10, 2018

Support for docker setup was added in #344, closing this.

@Ram81 Ram81 closed this Sep 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants