Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add proxy support to aws BPs - FULL #52

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add proxy support to aws BPs - FULL #52

wants to merge 2 commits into from

Conversation

oysterbank
Copy link
Contributor

@oysterbank oysterbank commented Feb 5, 2020 •
edited by jira bot
Loading

Development Prerequisites

Summary of Proposed Changes

  • AWS BPs need to support proxies.

@oysterbank
Add proxy support to aws BPs.
738b32d 
They need to use the TechnologyWrapper's methods.

[DEV-14551]
@pop pop self-requested a review February 5, 2020 21:35
@oysterbank oysterbank changed the title Add proxy support to aws BPs. Add proxy support to aws BPs - FULL Feb 5, 2020
pop
pop approved these changes Feb 5, 2020
View reviewed changes
Copy link
Contributor

@pop pop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still needs testing, but reading the code these changes look 👌 good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pop pop pop approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oysterbank @pop