Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the canonical URL if present #3

Closed
bglw opened this issue Sep 3, 2021 · 2 comments
Closed

Update the canonical URL if present #3

bglw opened this issue Sep 3, 2021 · 2 comments
Milestone
1.0 release

Comments

@bglw
Copy link
Contributor

bglw commented Sep 3, 2021

If a page contains a canonical URL, it should be updated to point the paginated page to itself.

If index.html contains:

<link rel="canonical" href="https://example.com/">

Then page/2/index.html should contain:

<link rel="canonical" href="https://example.com/page/2/">
@bglw bglw added this to the 1.0 release milestone Sep 3, 2021
bglw added a commit that referenced this issue Sep 9, 2021
@bglw
Adding spec for updating canonical URLs (issue #3)
bc943c7
@bglw
Copy link
Contributor Author

bglw commented Sep 9, 2021

Skipped test added in the above commit

Tate-CC added a commit that referenced this issue Sep 10, 2021
@Tate-CC
Implement more generic replacements (issue #3)
57f934b
@Tate-CC Tate-CC mentioned this issue Sep 10, 2021
Merged
@bglw
Copy link
Contributor Author

bglw commented Sep 12, 2021

Fixed in #17

@bglw bglw closed this as completed Sep 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0 release
Development

No branches or pull requests
1 participant
@bglw