Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor tests to new cucumber syntax and add parser tests #24

Merged
merged 8 commits into from
Nov 18, 2021
Merged

Conversation

bglw
Copy link
Contributor

@bglw bglw commented Nov 17, 2021

Highlights:

  • Uses new cucumber API
  • Moved PagebreakState.page_items into an Rc<RefCell<>> to make clippy happy
    • The previous remaining_items.drain(0..max_count).collect() angered clippy with it's redundant allocation
    • Rc<RefCell<>> is so we can drain the Vec into the closure where we mutate PagebreakState
  • Implemented parser-based step definitions using Kuchiki
  • Github action testing

@bglw bglw requested a review from Tate-CC November 17, 2021 07:39
Copy link
Contributor

@Tate-CC Tate-CC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤩

@bglw bglw merged commit c324ed5 into main Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add parser based tests to cucumber runner
2 participants