xskdev:keep FQ as full as possible #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It appears the FQ was not being kept as full as possible. The code would do a receive and then put back 64 mbufs, but the rx_burst() request may have been larger then 64 and it starts to deplete the FQ ring. It also appears when the FQ is low on packets the needs wakeup flag is always set and forces a poll() call, which I think then attempts to refill the NIC ring from the FQ and then increments the rx_fill_ring_emtpy counter. Signed-off-by: Keith Wiles <keith.wiles@intel.com>
maryamtahhan
approved these changes
Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears the FQ was not being kept as full as possible. The code would do a receive and
then put back 64 mbufs, but the rx_burst() request may have been larger then 64 and it
starts to deplete the FQ ring. It also appears when the FQ is low on packets the needs
wakeup flag is always set and forces a poll() call, which I think then attempts to refill
the NIC ring from the FQ and then increments the rx_fill_ring_emtpy counter.
Signed-off-by: Keith Wiles keith.wiles@intel.com