Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moved nametag code from cloudperms module to simplenametags plugin #457

Closed
wants to merge 4 commits into from
Closed

Moved nametag code from cloudperms module to simplenametags plugin #457

wants to merge 4 commits into from

Conversation

MCMDEV
Copy link
Contributor

@MCMDEV MCMDEV commented Apr 27, 2021

This pull request includes:

  • breaking changes
  • no breaking changes

Changes made to the repository:

Moved code for nametag handling from the CloudPerms Module into the SimpleNameTags Plugin.
As a result, the API-accessible updateNameTags methods were moved.
The corresponding example was also updated.

Documentation of test results:

Changes have been tested on a v3.3.0 Environment, everything works as expected.

Related issues/discussions:

@derklaro
Copy link
Member

Only pull requests targeting development are acceptable.

@byRoadrunner
Copy link
Member

byRoadrunner commented Apr 27, 2021 •
edited
Loading

Thank you for your pull request @MCMDEV, before we can review it please rebase your changes to the development branch. 🙂

@MCMDEV MCMDEV changed the base branch from master to development April 27, 2021 15:31
@MCMDEV
Copy link
Contributor Author

MCMDEV commented Apr 27, 2021

My bad, just changed that right now

@byRoadrunner
Copy link
Member

My bad, just changed that right now

Thanks, could you please also solve the merge conflicts?

0utplay
0utplay reviewed Apr 28, 2021
View reviewed changes
...etags/src/main/java/de/dytanic/cloudnet/ext/simplenametags/CloudNetSimpleNameTagsPlugin.java Outdated
}
}

int sortIdLength = CloudPermissionsManagement.getInstance().getGroups().stream()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CloudPermissionManagement is deprecated, we should use CloudNetDriver#getPermissionManagement

0utplay
0utplay reviewed Apr 28, 2021
View reviewed changes
...etags/src/main/java/de/dytanic/cloudnet/ext/simplenametags/CloudNetSimpleNameTagsPlugin.java Outdated
initScoreboard(player);

Bukkit.getOnlinePlayers().forEach(all -> {
initScoreboard(all);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this.

0utplay
0utplay reviewed Apr 28, 2021
View reviewed changes
...etags/src/main/java/de/dytanic/cloudnet/ext/simplenametags/CloudNetSimpleNameTagsPlugin.java Outdated
.max()
.orElse(0);

initScoreboard(player);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this.

@0utplay
Copy link
Member

0utplay commented Apr 28, 2021 •
edited
Loading

I think it would be easier if you copy the code from development into the simplenametags-plugin instead from the master?

@MCMDEV
Copy link
Contributor Author

MCMDEV commented Apr 28, 2021

Yeah, I guess I'll do that

@ghost
Copy link

ghost commented Apr 28, 2021

Congratulations 🎉. DeepCode analyzed your code in 3.869 seconds and we found no issues. Enjoy a moment of no bugs ☀️.

👉 View analysis in DeepCode’s Dashboard | Configure the bot

@MCMDEV
Copy link
Contributor Author

MCMDEV commented Apr 28, 2021

This PR is going to become an absolute mess, so I'm going to close this one and reopen it from from the development branch.

@MCMDEV MCMDEV closed this Apr 28, 2021
@MCMDEV MCMDEV mentioned this pull request Apr 28, 2021
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0utplay 0utplay 0utplay left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MCMDEV @derklaro @byRoadrunner @0utplay