-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delineate intersecting shards #16
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…repr of CaseInsensitiveString
… intersecting shards that are not subsets of each other
…nd an Allow shard.
…ap between allow shards and deny shards.
Sam-Martin
commented
Jan 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dedupe_policy_shards
todedupe_policy_shard_subsets
to differentiate it fromdelineate_intersecting_shards
.delineate_intersecting_shards
to reduce the size ofPolicyShard
s which have conditions whose ARPs intersect with ones without conditions.This helps clear up #10
issubset
onPolicyShard
to recognise that a shard without conditions CANNOT be a subset of a shard with conditions.<
and>
toPolicyShard
.difference
onPolicyShard
so that it only addsother
's conditions toself
's not_conditions if self is allow and other is deny.ConditionCollection
toRawConditionCollection
CaseInsensitiveString
that caused it to generate case sensitive hashes.dedupe_result
param todifference
method onPolicyShard
to allow merging of intersecting shards that are not subsets of one another.intersection
toPolicyShard
.