-
Notifications
You must be signed in to change notification settings - Fork 55
Conversation
…data/invalid.json
…stdata/sanderson.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately this PR still ages from before Autoscan's router was overhauled. We would still like to see this merged though.
However, as it stands, all -arr triggers are built on top of the old trigger architecture. Unlike A-Train, which is the sole trigger that makes use of the new architecture. So the question becomes: do we keep Readarr inline with the other -arrs or do we switch it over to the new architecture, as we do not have to account for backward compatibility? @l3uddz
Verbosity string `yaml:"verbosity"` | ||
} | ||
|
||
// New creates an autoscan-compatible HTTP Trigger for Lidarr webhooks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops, still mentions Lidarr
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it makes sense to have the comments fixed and then merge this.
At which point; we can refactor all the triggers to be in line with the new architecture as a separate PR?
So I'm afraid that bridging all triggers to the new architecture is a breaking change. A-Train accepts Bridging the triggers to the new architecture would force us to use But I'm not keen on the route having sonarr in there twice. Ideally, We could write a migration script for this to get away with introducing a breaking change though. |
First rough attempt at adding a Readarr trigger using Lidarr's trigger as a base. Additional events for Lidarr/Readarr pending until OnDelete is merged with both of them (Rename + OnDelete both pending)