Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug events break duration #846

Open
ghost opened this issue Aug 14, 2019 · 4 comments
Open

Bug events break duration #846

ghost opened this issue Aug 14, 2019 · 4 comments

Comments

@ghost
Copy link

ghost commented Aug 14, 2019

If an event is cancelled and you still break item, breaktime is not reseted.


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@PetteriM1
Copy link
Member

Please follow the issue template

@ghost
Copy link
Author

ghost commented Aug 14, 2019

You really? It's that important?

I will give you these:

raknet-branch, 1.12.0, bla bla, latest version from raknet.
b
How to reproduce:

Make an event and close it and continue to break:

@EventHandler
public void onBreak(BlockBreakEvent event) {
Block block = event.getBlock();
Player player = event.getPlayer();
player.getInventory().addItem(item);
event.setCancelled();
}

You will see you will get items faster then normal (or faster then first break) and that means breakTime is not reseted on event blocked.

Was hard?:/

@PetteriM1
Copy link
Member

You really? It's that important?

I will give you these:

raknet-branch, 1.12.0, bla bla, latest version from raknet.
b
How to reproduce:

Make an event and close it and continue to break:

@EventHandler
public void onBreak(BlockBreakEvent event) {
Block block = event.getBlock();
Player player = event.getPlayer();
player.getInventory().addItem(item);
event.setCancelled();
}

You will see you will get items faster then normal (or faster then first break) and that means breakTime is not reseted on event blocked.

Was hard?:/

Yes that is important. For example you didn't mention the new raknet branch before.

@ghost
Copy link
Author

ghost commented Aug 15, 2019

It doesn't care.

KCodeYT pushed a commit to KCodeYT/Nukkit that referenced this issue Jan 9, 2021
KCodeYT pushed a commit to KCodeYT/Nukkit that referenced this issue Jan 9, 2021
KCodeYT pushed a commit to KCodeYT/Nukkit that referenced this issue Jan 9, 2021
[v1.3.x] Pull changes from upstream (master)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant